mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-23 23:20:51 +01:00
[PR #1817] [MERGED] Change PRAGMA mode from WAL to TRUNCATE #8726
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#8726
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/1817
Author: @joshuaboniface
Created: 9/29/2019
Status: ✅ Merged
Merged: 9/29/2019
Merged by: @joshuaboniface
Base:
master← Head:change-pragma-mode📝 Commits (2)
72edf5bChange PRAGMA mode from WAL to TRUNCATE9aec21fNicer link format for comment📊 Changes
1 file changed (+2 additions, -2 deletions)
View changed files
📝
Emby.Server.Implementations/Data/BaseSqliteRepository.cs(+2 -2)📄 Description
Changes
As-is, the WAL mode for SQLite3 has problems where the WAL isn't flushed properly, resulting in the file ballooning to massive sizes and filling up disks. Instead, we change to TRUNCATE mode. This mode (as per https://www.sqlite.org/pragma.html#pragma_journal_mode) uses a traditional journal which is flushed via a truncation (rather than file delete), which removes the WAL problems, preserving write journaling, while also not having any overhead for file deletion/creation to the system.
Issues
Fixes #1655
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.