mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-23 23:20:51 +01:00
[10.11.0-RC.2] TrickplayInfo missing newly added ItemId field causing deserialization issues #7100
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#7100
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nielsvanvelzen on GitHub (Jun 16, 2025).
In the 10.11 based API a new "ItemId" property was added to TrickplayInfo. Most likely unintentionally because we just push the EF entity towards the API layer (which we should not..).
https://github.com/jellyfin/jellyfin-sdk-kotlin/blame/39dad1a27f46f4cdb81930ccae09e31935255d4a/jellyfin-model/src/commonMain/kotlin-generated/org/jellyfin/sdk/model/api/TrickplayInfo.kt#L22-L26
However, in the ATV app I see a LOT of deserialization issues because this item id is not (always?) populated by the server. Tested using the unstable demo server. At least the getLatestMedia and getNextUp API operations trigger this issue but there might be more.
@nielsvanvelzen commented on GitHub (Jun 16, 2025):
Most likely caused by this change from #13945. I propose fixing it by adding a proper DTO type for the API layer to avoid this issue in the future. the dto would not contain the item id.
fe2596dc0e (diff-6490c9a80416d9a3175b594c96345359f531762495982aad287e6f1c02450667L17)