[PR #14795] [MERGED] Temp/options and isplayed #13945

New issue

Closed

opened 2025-12-22 10:13:11 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 10:13:11 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14795
Author: @JPVenson
Created: 9/13/2025
Status: ✅ Merged
Merged: 9/16/2025
Merged by: @crobibero

Base: master ← Head: temp/OptionsAndIsplayed

📝 Commits (10+)

9d60329 Revert IsPlayed optimization, pass UserItemData to IsPlayed when available
f1d5690 Reenable common PRAGA setters
31514ba Cache cmd creation
cdbe948 Fix nullabilitiy
a6b0ceb Populate pragma options from DB settings
27f6a1e Add async interceptor too
fdcf576 Merge remote-tracking branch 'cody-gh/is-played' into temp/OptionsAndIsplayed
0a7665d Query UserData
1f62657 Introduce Count Query
92176ff Limit resultset to Limit when supplied

📊 Changes

20 files changed (+1988 additions, -92 deletions)

View changed files

📝 Emby.Server.Implementations/Library/LibraryManager.cs (+7 -3)
📝 Emby.Server.Implementations/Library/MusicManager.cs (+8 -5)
📝 Emby.Server.Implementations/Library/UserDataManager.cs (+6 -2)
📝 Jellyfin.Api/Controllers/YearsController.cs (+3 -2)
📝 Jellyfin.Server.Implementations/Item/BaseItemRepository.cs (+82 -22)
📝 Jellyfin.Server.Implementations/Item/PeopleRepository.cs (+4 -2)
📝 MediaBrowser.Controller/Entities/BaseItem.cs (+7 -0)
📝 MediaBrowser.Controller/Entities/Folder.cs (+76 -46)
📝 MediaBrowser.Controller/Entities/Movies/BoxSet.cs (+2 -2)
📝 MediaBrowser.Controller/Entities/TV/Season.cs (+1 -1)
📝 MediaBrowser.Controller/Entities/TV/Series.cs (+1 -0)
📝 MediaBrowser.Controller/Entities/UserView.cs (+6 -4)
📝 MediaBrowser.Controller/Persistence/IItemRepository.cs (+10 -0)
📝 MediaBrowser.Controller/Playlists/Playlist.cs (+4 -2)
📝 src/Jellyfin.Database/Jellyfin.Database.Implementations/Entities/BaseItemEntity.cs (+4 -0)
📝 src/Jellyfin.Database/Jellyfin.Database.Implementations/ModelConfiguration/BaseItemConfiguration.cs (+1 -0)
➕ src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/Migrations/20250913211637_AddProperParentChildRelationBaseItemWithCascade.Designer.cs (+1721 -0)
➕ src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/Migrations/20250913211637_AddProperParentChildRelationBaseItemWithCascade.cs (+30 -0)
📝 src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/Migrations/JellyfinDbModelSnapshot.cs (+13 -1)
📝 tests/Jellyfin.Server.Integration.Tests/Controllers/LibraryStructureControllerTests.cs (+2 -0)

📄 Description

It somehow works like this

Builds upon #14791 and #14786

Cache a Folders "Children" instead of requerying them every time
Improve internal querying to respect "Limit" parameter on querytime instead of applying it server side
Query UserData with each BaseItem instead of requesting it individually
Introduce dedicated "IsPlayed" query to recusively check a folder
Reintroduce Transaction on Peoples to prevent FK collision
Introduce FK for ParentId relation and cascade delete on it to ensure proper cleanup after library deletion

Squash pls

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14795 **Author:** [@JPVenson](https://github.com/JPVenson) **Created:** 9/13/2025 **Status:** ✅ Merged **Merged:** 9/16/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `temp/OptionsAndIsplayed` --- ### 📝 Commits (10+) - [`9d60329`](https://github.com/jellyfin/jellyfin/commit/9d603293dc1bd8caaaa5370e42399f85c6de65a5) Revert IsPlayed optimization, pass UserItemData to IsPlayed when available - [`f1d5690`](https://github.com/jellyfin/jellyfin/commit/f1d5690af8b5b48c916fa6ff6f0df8023b68f439) Reenable common PRAGA setters - [`31514ba`](https://github.com/jellyfin/jellyfin/commit/31514bacc3d32e884d23a9559bc2a79e0d25b2bc) Cache cmd creation - [`cdbe948`](https://github.com/jellyfin/jellyfin/commit/cdbe94829169539caa397327a8166562816e08f3) Fix nullabilitiy - [`a6b0ceb`](https://github.com/jellyfin/jellyfin/commit/a6b0ceb12f16a1aa08799fd522e0975a38e41186) Populate pragma options from DB settings - [`27f6a1e`](https://github.com/jellyfin/jellyfin/commit/27f6a1edc88f8d0680dcf187b511fd9a17b37e26) Add async interceptor too - [`fdcf576`](https://github.com/jellyfin/jellyfin/commit/fdcf576a4e5c89811823c1853cb0a51157ca2c30) Merge remote-tracking branch 'cody-gh/is-played' into temp/OptionsAndIsplayed - [`0a7665d`](https://github.com/jellyfin/jellyfin/commit/0a7665d0caebb6504e5bbf34c896518cf8308f7b) Query UserData - [`1f62657`](https://github.com/jellyfin/jellyfin/commit/1f6265749e76a43596b68636141af9924c29f505) Introduce Count Query - [`92176ff`](https://github.com/jellyfin/jellyfin/commit/92176ff4d4fa44e103604d9656e05f6bddd4dce7) Limit resultset to Limit when supplied ### 📊 Changes **20 files changed** (+1988 additions, -92 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+7 -3) 📝 `Emby.Server.Implementations/Library/MusicManager.cs` (+8 -5) 📝 `Emby.Server.Implementations/Library/UserDataManager.cs` (+6 -2) 📝 `Jellyfin.Api/Controllers/YearsController.cs` (+3 -2) 📝 `Jellyfin.Server.Implementations/Item/BaseItemRepository.cs` (+82 -22) 📝 `Jellyfin.Server.Implementations/Item/PeopleRepository.cs` (+4 -2) 📝 `MediaBrowser.Controller/Entities/BaseItem.cs` (+7 -0) 📝 `MediaBrowser.Controller/Entities/Folder.cs` (+76 -46) 📝 `MediaBrowser.Controller/Entities/Movies/BoxSet.cs` (+2 -2) 📝 `MediaBrowser.Controller/Entities/TV/Season.cs` (+1 -1) 📝 `MediaBrowser.Controller/Entities/TV/Series.cs` (+1 -0) 📝 `MediaBrowser.Controller/Entities/UserView.cs` (+6 -4) 📝 `MediaBrowser.Controller/Persistence/IItemRepository.cs` (+10 -0) 📝 `MediaBrowser.Controller/Playlists/Playlist.cs` (+4 -2) 📝 `src/Jellyfin.Database/Jellyfin.Database.Implementations/Entities/BaseItemEntity.cs` (+4 -0) 📝 `src/Jellyfin.Database/Jellyfin.Database.Implementations/ModelConfiguration/BaseItemConfiguration.cs` (+1 -0) ➕ `src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/Migrations/20250913211637_AddProperParentChildRelationBaseItemWithCascade.Designer.cs` (+1721 -0) ➕ `src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/Migrations/20250913211637_AddProperParentChildRelationBaseItemWithCascade.cs` (+30 -0) 📝 `src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/Migrations/JellyfinDbModelSnapshot.cs` (+13 -1) 📝 `tests/Jellyfin.Server.Integration.Tests/Controllers/LibraryStructureControllerTests.cs` (+2 -0) </details> ### 📄 Description It somehow works like this Builds upon #14791 and #14786 - Cache a Folders "Children" instead of requerying them every time - Improve internal querying to respect "Limit" parameter on querytime instead of applying it server side - Query UserData with each BaseItem instead of requesting it individually - Introduce dedicated "IsPlayed" query to recusively check a folder - Reintroduce Transaction on Peoples to prevent FK collision - Introduce FK for ParentId relation and cascade delete on it to ensure proper cleanup after library deletion Squash pls --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 10:13:11 +01:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#13945

No description provided.

Rows
Columns