[PR #4587] [CLOSED] Reduction in code nesting in networkManager. #9996

Closed
opened 2025-12-22 07:47:29 +01:00 by backuprepo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4587
Author: @BaronGreenback
Created: 11/25/2020
Status: Closed

Base: masterHead: NetworkManagerOptimization


📝 Commits (5)

  • dc1cec9 Merge pull request #98 from jellyfin/master
  • 2dacaa5 Changes as recommended by ReSharper.
  • fcd0c9f Merge branch 'master' into NetworkManagerOptimization
  • f2290aa simplification
  • 3e2972c Merge branch 'master' into NetworkManagerOptimization

📊 Changes

7 files changed (+347 additions, -362 deletions)

View changed files

📝 Jellyfin.Networking/Configuration/NetworkConfigurationExtensions.cs (+0 -1)
📝 Jellyfin.Networking/Manager/NetworkManager.cs (+195 -173)
📝 MediaBrowser.Common/Net/INetworkManager.cs (+0 -1)
📝 MediaBrowser.Common/Net/IPHost.cs (+58 -62)
📝 MediaBrowser.Common/Net/IPNetAddress.cs (+23 -23)
📝 MediaBrowser.Common/Net/IPObject.cs (+66 -64)
📝 MediaBrowser.Common/Net/NetworkExtensions.cs (+5 -38)

📄 Description

Implemented changes as recommended by ReSharper.

99.9% of the changes are code nesting reductions.
The rest are suggested optimisations.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4587 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 11/25/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `NetworkManagerOptimization` --- ### 📝 Commits (5) - [`dc1cec9`](https://github.com/jellyfin/jellyfin/commit/dc1cec9fd82af8742cf2b20f2da1fdf1de6bd41d) Merge pull request #98 from jellyfin/master - [`2dacaa5`](https://github.com/jellyfin/jellyfin/commit/2dacaa529656463df2f5671b326559c753ac118f) Changes as recommended by ReSharper. - [`fcd0c9f`](https://github.com/jellyfin/jellyfin/commit/fcd0c9f1bef6cee37a58ad8660c153082470300a) Merge branch 'master' into NetworkManagerOptimization - [`f2290aa`](https://github.com/jellyfin/jellyfin/commit/f2290aaaf0533ac92b3ba6e816478a802943ed76) simplification - [`3e2972c`](https://github.com/jellyfin/jellyfin/commit/3e2972c893e25ab30fe2256e717e2eb85af793e8) Merge branch 'master' into NetworkManagerOptimization ### 📊 Changes **7 files changed** (+347 additions, -362 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Networking/Configuration/NetworkConfigurationExtensions.cs` (+0 -1) 📝 `Jellyfin.Networking/Manager/NetworkManager.cs` (+195 -173) 📝 `MediaBrowser.Common/Net/INetworkManager.cs` (+0 -1) 📝 `MediaBrowser.Common/Net/IPHost.cs` (+58 -62) 📝 `MediaBrowser.Common/Net/IPNetAddress.cs` (+23 -23) 📝 `MediaBrowser.Common/Net/IPObject.cs` (+66 -64) 📝 `MediaBrowser.Common/Net/NetworkExtensions.cs` (+5 -38) </details> ### 📄 Description Implemented changes as recommended by ReSharper. 99.9% of the changes are code nesting reductions. The rest are suggested optimisations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
backuprepo 2025-12-22 07:47:29 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#9996
No description provided.