mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-23 23:20:51 +01:00
[PR #4587] [CLOSED] Reduction in code nesting in networkManager. #9996
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#9996
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/4587
Author: @BaronGreenback
Created: 11/25/2020
Status: ❌ Closed
Base:
master← Head:NetworkManagerOptimization📝 Commits (5)
dc1cec9Merge pull request #98 from jellyfin/master2dacaa5Changes as recommended by ReSharper.fcd0c9fMerge branch 'master' into NetworkManagerOptimizationf2290aasimplification3e2972cMerge branch 'master' into NetworkManagerOptimization📊 Changes
7 files changed (+347 additions, -362 deletions)
View changed files
📝
Jellyfin.Networking/Configuration/NetworkConfigurationExtensions.cs(+0 -1)📝
Jellyfin.Networking/Manager/NetworkManager.cs(+195 -173)📝
MediaBrowser.Common/Net/INetworkManager.cs(+0 -1)📝
MediaBrowser.Common/Net/IPHost.cs(+58 -62)📝
MediaBrowser.Common/Net/IPNetAddress.cs(+23 -23)📝
MediaBrowser.Common/Net/IPObject.cs(+66 -64)📝
MediaBrowser.Common/Net/NetworkExtensions.cs(+5 -38)📄 Description
Implemented changes as recommended by ReSharper.
99.9% of the changes are code nesting reductions.
The rest are suggested optimisations.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.