[PR #4182] [MERGED] Fix HD Home Run streaming #9751

New issue

Closed

opened 2025-12-22 07:39:01 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 07:39:01 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4182
Author: @ryanpetris
Created: 9/19/2020
Status: ✅ Merged
Merged: 11/21/2020
Merged by: @joshuaboniface

Base: master ← Head: fix-hdhomerun

📝 Commits (4)

0496e18 Fix HD Home Run streaming.
361f51a Use TcpClient.Connect().
81d5eb4 Return a Task object and discard it instead of using async void.
8204b25 Merge branch 'master' into fix-hdhomerun

📊 Changes

2 files changed (+52 additions, -50 deletions)

View changed files

📝 Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunManager.cs (+26 -25)
📝 Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunUdpStream.cs (+26 -25)

📄 Description

HD Home Run (HDHR3-US) streams never start from the Jellyfin Web UI. The following modifications allow live streams to start properly.

Changes

Use LocalEndPoint instead of RemoteEndPoint when determining local address.
HdHomerunUdpStream.StartStreaming is meant to run until stream is closed, however HdHomerunUdpStream.Open needs to return as soon as stream is open to send stream url back to client. Therefore, StartStreaming should not be awaited on.
TcpClient(IPEndPoint) treats endpoint as the local endpoint; use TcpClient(string, int) instead as it treats endpoint as the remote endpoint.

Issues
I believe this fixes Issue #1391

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4182 **Author:** [@ryanpetris](https://github.com/ryanpetris) **Created:** 9/19/2020 **Status:** ✅ Merged **Merged:** 11/21/2020 **Merged by:** [@joshuaboniface](https://github.com/joshuaboniface) **Base:** `master` ← **Head:** `fix-hdhomerun` --- ### 📝 Commits (4) - [`0496e18`](https://github.com/jellyfin/jellyfin/commit/0496e1817923149f3d99d8e588efcaa2fbc5be1d) Fix HD Home Run streaming. - [`361f51a`](https://github.com/jellyfin/jellyfin/commit/361f51ac944184cbde3768818bc68e5cfee8e857) Use TcpClient.Connect(). - [`81d5eb4`](https://github.com/jellyfin/jellyfin/commit/81d5eb4db5918debe3194236288492f26ad135bb) Return a Task object and discard it instead of using async void. - [`8204b25`](https://github.com/jellyfin/jellyfin/commit/8204b25a56af7ddb20497f3d7ad8e1d8daaff7ca) Merge branch 'master' into fix-hdhomerun ### 📊 Changes **2 files changed** (+52 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunManager.cs` (+26 -25) 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunUdpStream.cs` (+26 -25) </details> ### 📄 Description HD Home Run (HDHR3-US) streams never start from the Jellyfin Web UI. The following modifications allow live streams to start properly. **Changes** * Use LocalEndPoint instead of RemoteEndPoint when determining local address. * HdHomerunUdpStream.StartStreaming is meant to run until stream is closed, however HdHomerunUdpStream.Open needs to return as soon as stream is open to send stream url back to client. Therefore, StartStreaming should not be awaited on. * TcpClient(IPEndPoint) treats endpoint as the local endpoint; use TcpClient(string, int) instead as it treats endpoint as the remote endpoint. **Issues** I believe this fixes Issue #1391 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 07:39:01 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 09:04:38 +01:00

[PR #9751] [MERGED] chore(deps): update dependency serilog.aspnetcore to v7 #12033

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#9751

No description provided.

Rows
Columns