[PR #4162] [MERGED] Fix for #4161: BaseUrl in DLNA #9738

New issue

Closed

opened 2025-12-22 07:38:39 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 07:38:39 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4162
Author: @BaronGreenback
Created: 9/16/2020
Status: ✅ Merged
Merged: 9/27/2020
Merged by: @Bond-009

Base: master ← Head: DlnaServerBaseUrlFix

📝 Commits (4)

86ad04b Update DescriptionXmlBuilder.cs
c2e2e5a Update DescriptionXmlBuilder.cs
a6400d1 Update DescriptionXmlBuilder.cs
d99db54 Update DescriptionXmlBuilder.cs

📊 Changes

1 file changed (+11 additions, -5 deletions)

View changed files

📝 Emby.Dlna/Server/DescriptionXmlBuilder.cs (+11 -5)

📄 Description

The dlna server used the DLNA base url functionality within its descriptions, enabling shorter url's to be used within it xml description.

However, it looks like this shorting of service urls is not supported (at least in UPnP Tools - which I have to assume is correct).

The result is that services cannot be parsed. eg, Look at the serviceUrl - BaseUrl is set to Jellyfin/

Before fix:

After fix: (DescriptionXMLBuilder.cs BuildUrl (270))

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4162 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 9/16/2020 **Status:** ✅ Merged **Merged:** 9/27/2020 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `DlnaServerBaseUrlFix` --- ### 📝 Commits (4) - [`86ad04b`](https://github.com/jellyfin/jellyfin/commit/86ad04b6571a9e44744f135caac768e8f1acdcde) Update DescriptionXmlBuilder.cs - [`c2e2e5a`](https://github.com/jellyfin/jellyfin/commit/c2e2e5ac0ce298e550a02eeb2e853497d7f9e647) Update DescriptionXmlBuilder.cs - [`a6400d1`](https://github.com/jellyfin/jellyfin/commit/a6400d12c9bd8e32497f6510fe7491fd0325650a) Update DescriptionXmlBuilder.cs - [`d99db54`](https://github.com/jellyfin/jellyfin/commit/d99db543daf770a059830627dbdc255ae6abe42e) Update DescriptionXmlBuilder.cs ### 📊 Changes **1 file changed** (+11 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/Server/DescriptionXmlBuilder.cs` (+11 -5) </details> ### 📄 Description The dlna server used the DLNA base url functionality within its descriptions, enabling shorter url's to be used within it xml description. However, it looks like this shorting of service urls is not supported (at least in UPnP Tools - which I have to assume is correct). The result is that services cannot be parsed. eg, **Look at the serviceUrl** - BaseUrl is set to Jellyfin/ Before fix: ![image](https://user-images.githubusercontent.com/22121540/93328586-d633af80-f813-11ea-9910-c79a4f5d9e3a.png) After fix: (DescriptionXMLBuilder.cs BuildUrl (270)) ![image](https://user-images.githubusercontent.com/22121540/93328357-848b2500-f813-11ea-836e-ecd090fb4a01.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>