[PR #3597] [MERGED] Jellyfin.Drawing.Skia Cleanup #9446

New issue

Closed

opened 2025-12-22 07:29:00 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 07:29:00 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3597
Author: @barronpm
Created: 7/19/2020
Status: ✅ Merged
Merged: 7/26/2020
Merged by: @anthonylavado

Base: master ← Head: jellyfin-drawing-skia-cleanup

📝 Commits (10+)

196e8e1 Convert to using declarations
bd77f1e Remove redundant casts
87b8a8d Simplify arithmetic
1be3e1e Remove unnecessary base constructor calls.
a9806d8 Convert to switch expressions
d983d65 Simplify return statements
2569793 Reuse paint objects.
b51a109 Rewrite OrientImage
4a356ef Make constructor one line
36b0515 Rewrite CropWhitespace

📊 Changes

7 files changed (+263 additions, -441 deletions)

View changed files

📝 Jellyfin.Drawing.Skia/PercentPlayedDrawer.cs (+9 -13)
📝 Jellyfin.Drawing.Skia/PlayedIndicatorDrawer.cs (+15 -19)
📝 Jellyfin.Drawing.Skia/SkiaCodecException.cs (+1 -1)
📝 Jellyfin.Drawing.Skia/SkiaEncoder.cs (+162 -310)
📝 Jellyfin.Drawing.Skia/SkiaException.cs (+1 -1)
📝 Jellyfin.Drawing.Skia/StripCollageBuilder.cs (+51 -69)
📝 Jellyfin.Drawing.Skia/UnplayedCountIndicator.cs (+24 -28)

📄 Description

Changes
Cleans up code in Jellyfin.Drawing.Skia. Also rewrites a couple of functions for readability/performance.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3597 **Author:** [@barronpm](https://github.com/barronpm) **Created:** 7/19/2020 **Status:** ✅ Merged **Merged:** 7/26/2020 **Merged by:** [@anthonylavado](https://github.com/anthonylavado) **Base:** `master` ← **Head:** `jellyfin-drawing-skia-cleanup` --- ### 📝 Commits (10+) - [`196e8e1`](https://github.com/jellyfin/jellyfin/commit/196e8e131a4d42dbdadb337bad72bd32e0c68624) Convert to using declarations - [`bd77f1e`](https://github.com/jellyfin/jellyfin/commit/bd77f1e84ffad72ccf78231181f392a6948f58a7) Remove redundant casts - [`87b8a8d`](https://github.com/jellyfin/jellyfin/commit/87b8a8d7c76e7b59651a7436e895d64c5001de4b) Simplify arithmetic - [`1be3e1e`](https://github.com/jellyfin/jellyfin/commit/1be3e1e0379b0fdce9f16739bbd58ea34f85f931) Remove unnecessary base constructor calls. - [`a9806d8`](https://github.com/jellyfin/jellyfin/commit/a9806d8f4a4ae2069532c7bd44e4e76cc2b62f6b) Convert to switch expressions - [`d983d65`](https://github.com/jellyfin/jellyfin/commit/d983d65d8abdef7a71c935d134ab5d8bce3ee858) Simplify return statements - [`2569793`](https://github.com/jellyfin/jellyfin/commit/2569793ff08a6331dacf1513bd74c6572e28fa50) Reuse paint objects. - [`b51a109`](https://github.com/jellyfin/jellyfin/commit/b51a10948a78932e1d96d44841e2608b08920e7a) Rewrite OrientImage - [`4a356ef`](https://github.com/jellyfin/jellyfin/commit/4a356efa2c54d67609ec2cbd6db9187179a1ee93) Make constructor one line - [`36b0515`](https://github.com/jellyfin/jellyfin/commit/36b05157f0ae9e780b11c39f17d23ceae05ec7b5) Rewrite CropWhitespace ### 📊 Changes **7 files changed** (+263 additions, -441 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Drawing.Skia/PercentPlayedDrawer.cs` (+9 -13) 📝 `Jellyfin.Drawing.Skia/PlayedIndicatorDrawer.cs` (+15 -19) 📝 `Jellyfin.Drawing.Skia/SkiaCodecException.cs` (+1 -1) 📝 `Jellyfin.Drawing.Skia/SkiaEncoder.cs` (+162 -310) 📝 `Jellyfin.Drawing.Skia/SkiaException.cs` (+1 -1) 📝 `Jellyfin.Drawing.Skia/StripCollageBuilder.cs` (+51 -69) 📝 `Jellyfin.Drawing.Skia/UnplayedCountIndicator.cs` (+24 -28) </details> ### 📄 Description **Changes** Cleans up code in Jellyfin.Drawing.Skia. Also rewrites a couple of functions for readability/performance. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 07:29:00 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 09:01:24 +01:00

[PR #9446] [MERGED] Audiobook grouping fixes #11933

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#9446

No description provided.

Rows
Columns