[PR #2715] [MERGED] Prefer to use libfdk_aac encoder for better audio quality when it is available #9014

New issue

Closed

opened 2025-12-22 07:15:12 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 07:15:12 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/2715
Author: @nyanmisaka
Created: 3/30/2020
Status: ✅ Merged
Merged: 4/12/2020
Merged by: @joshuaboniface

Base: master ← Head: libfdk-aac

📝 Commits (4)

db23660 prefer to use libfdk_aac for better audio quality
cf98a1f update as per suggestion
ebb7590 update as per suggestion
d9b78a1 update as per suggestion

📊 Changes

2 files changed (+8 additions, -1 deletions)

View changed files

📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+7 -1)
📝 MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs (+1 -0)

📄 Description

Changes

This PR was proposed by @PeterCxy.

Currently, Jellyfin always tries to use the default aac encoder in ffmpeg when transcoding audio (for both video files and standalone music files). This encoder is fine for most purposes, but sometimes it produces some really jarring distortion at higher frequencies. It would be nice to be able to use a better aac encoder, however even if ffmpeg is built with libfdk_aac enabled, Jellyfin still uses the default aac encoder.

The library is also incompatible with GPL. Users would still need to supply their own build of FFmpeg to make this work, as libfdk_aac could not be redistributed.

https://ffmpeg.org/ffmpeg-all.html#libfdk_005faac

Issues
Fixes: https://github.com/jellyfin/jellyfin/issues/2705

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/2715 **Author:** [@nyanmisaka](https://github.com/nyanmisaka) **Created:** 3/30/2020 **Status:** ✅ Merged **Merged:** 4/12/2020 **Merged by:** [@joshuaboniface](https://github.com/joshuaboniface) **Base:** `master` ← **Head:** `libfdk-aac` --- ### 📝 Commits (4) - [`db23660`](https://github.com/jellyfin/jellyfin/commit/db2366066029fa8e261d308d9db845070c0b9ca4) prefer to use libfdk_aac for better audio quality - [`cf98a1f`](https://github.com/jellyfin/jellyfin/commit/cf98a1fbc7be2cb58d348225ae450dddae0038d3) update as per suggestion - [`ebb7590`](https://github.com/jellyfin/jellyfin/commit/ebb7590350bc50e65e6b2834de60671390a50ce9) update as per suggestion - [`d9b78a1`](https://github.com/jellyfin/jellyfin/commit/d9b78a1dc5f3cbabafc6393887762815a23e2bac) update as per suggestion ### 📊 Changes **2 files changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+7 -1) 📝 `MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs` (+1 -0) </details> ### 📄 Description **Changes** This PR was proposed by @PeterCxy. > Currently, Jellyfin always tries to use the default aac encoder in ffmpeg when transcoding audio (for both video files and standalone music files). This encoder is fine for most purposes, but sometimes it produces some really jarring distortion at higher frequencies. It would be nice to be able to use a better aac encoder, however even if ffmpeg is built with libfdk_aac enabled, Jellyfin still uses the default aac encoder. The library is also incompatible with GPL. Users would still need to supply their own build of FFmpeg to make this work, as libfdk_aac could not be redistributed. https://ffmpeg.org/ffmpeg-all.html#libfdk_005faac **Issues** Fixes: https://github.com/jellyfin/jellyfin/issues/2705 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 07:15:12 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 08:55:51 +01:00

[PR #9014] [MERGED] Deduplicate media stream ordering code #11761

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#9014

No description provided.

Rows
Columns