mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-23 23:20:51 +01:00
[PR #2071] [MERGED] add filesize limit for logfiles and a maximum logfile count #8812
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#8812
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/2071
Author: @excelite
Created: 11/28/2019
Status: ✅ Merged
Merged: 11/29/2019
Merged by: @JustAMan
Base:
master← Head:add_default_values_to_logconfig📝 Commits (1)
6069134added filesize limit for logfiles and a maximum logfile count📊 Changes
1 file changed (+3 additions, -0 deletions)
View changed files
📝
Jellyfin.Server/Resources/Configuration/logging.json(+3 -0)📄 Description
Changes
Adds default values to logger config by using the loggers configuration arguments.
Issues
Fixes #2056
Fixes #2069
Detailed description
This PR adds the following default values to the shipped logging configuration:
The number of the retained logfiles is derived from the default value of the logfile cleanup task that sets the age of logfiles to three days. Since the time based logfile rotation is set to "Days" interval this would result in three logfiles to keep.
The default logfile size was chosen to ensure that limited memory devices like a raspberry can handle the logfile size with still sufficient ressources left for other processes.
Looking at personal logfile sizes of a 5 user instance with multiple day-to-day usage files range between 10MB to 30MB), a default value of 100MB should cover a large percentage of the userbase without adjustments.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.