[PR #1929] [MERGED] Fix parsing of certain names and adds a default season if no season was found #8773

New issue

Closed

opened 2025-12-22 07:06:50 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 07:06:50 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/1929
Author: @Narfinger
Created: 10/22/2019
Status: ✅ Merged
Merged: 11/7/2019
Merged by: @dkanada

Base: master ← Head: parser-fix4

📝 Commits (4)

8da012c add tests for Emby.Naming/TV/EpisodePathParser.cs
45f906c added a couple more tests
4a20260 add another parser case and allow parsing of seasonless
9cd62d6 removed restriction to 3 digits in episodenumber and 4 in season numbers

📊 Changes

5 files changed (+103 additions, -9 deletions)

View changed files

📝 Emby.Naming/Common/NamingOptions.cs (+12 -8)
📝 Emby.Server.Implementations/Library/LibraryManager.cs (+10 -1)
📝 MediaBrowser.sln (+7 -0)
➕ tests/Jellyfin.Naming.Tests/EpisodePathParserTest.cs (+54 -0)
➕ tests/Jellyfin.Naming.Tests/Jellyfin.Naming.Tests.csproj (+20 -0)

📄 Description

This patch fixed some parsing errors for files found in the anime community.

This pull request includes the test cases from my previous pull request (https://github.com/jellyfin/jellyfin/pull/1877).

I tested this patch and it now parses quite a few more files on my system, however, the tests do not seem to work. If somebody could help out with figuring out why the test cases do not work, I would be very happy.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/1929 **Author:** [@Narfinger](https://github.com/Narfinger) **Created:** 10/22/2019 **Status:** ✅ Merged **Merged:** 11/7/2019 **Merged by:** [@dkanada](https://github.com/dkanada) **Base:** `master` ← **Head:** `parser-fix4` --- ### 📝 Commits (4) - [`8da012c`](https://github.com/jellyfin/jellyfin/commit/8da012c8c507b6a177cfff233cfdac3490f79847) add tests for Emby.Naming/TV/EpisodePathParser.cs - [`45f906c`](https://github.com/jellyfin/jellyfin/commit/45f906c5564d8ecbc3d6d1cabcd78e929a9fb7e1) added a couple more tests - [`4a20260`](https://github.com/jellyfin/jellyfin/commit/4a20260a27e8ede4188609d8206a7313f7243e97) add another parser case and allow parsing of seasonless - [`9cd62d6`](https://github.com/jellyfin/jellyfin/commit/9cd62d661f3209ddf411faf5936e2483b532fadb) removed restriction to 3 digits in episodenumber and 4 in season numbers ### 📊 Changes **5 files changed** (+103 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Naming/Common/NamingOptions.cs` (+12 -8) 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+10 -1) 📝 `MediaBrowser.sln` (+7 -0) ➕ `tests/Jellyfin.Naming.Tests/EpisodePathParserTest.cs` (+54 -0) ➕ `tests/Jellyfin.Naming.Tests/Jellyfin.Naming.Tests.csproj` (+20 -0) </details> ### 📄 Description This patch fixed some parsing errors for files found in the anime community. This pull request includes the test cases from my previous pull request (https://github.com/jellyfin/jellyfin/pull/1877). I tested this patch and it now parses quite a few more files on my system, however, the tests do not seem to work. If somebody could help out with figuring out why the test cases do not work, I would be very happy. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 07:06:50 +01:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#8773

No description provided.

Rows
Columns