[PR #1903] [MERGED] Update NSIS Installer #8763

New issue

Closed

opened 2025-12-22 07:06:26 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 07:06:26 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/1903
Author: @anthonylavado
Created: 10/16/2019
Status: ✅ Merged
Merged: 11/3/2019
Merged by: @joshuaboniface

Base: master ← Head: nsis-update

📝 Commits (10+)

c8ffa2f Set service install default to no
04c4ad7 Begin to add setup type dialog
05fb84b Make service setup an optional component, remove setuptype page config for now
9ad7813 Fix up Setup Type dialog, and add logic for basic setup
f80343b Fix the Setup Type dialog titles
dc46620 Automatically creates shortcuts for non-service installs
5232302 Adds icons to shortcuts, fixes nsis warning
63e0bd1 Only create/remove shortcuts on non-service install
6f504a2 Use the registry path for datadir, don't override it here
330395e Check for the presence of AppDataLocal folder before using it

📊 Changes

5 files changed (+207 additions, -19 deletions)

View changed files

📝 .ci/azure-pipelines.yml (+1 -1)
📝 deployment/windows/build-jellyfin.ps1 (+22 -0)
➕ deployment/windows/dialogs/setuptype.nsddef (+12 -0)
➕ deployment/windows/dialogs/setuptype.nsdinc (+50 -0)
📝 deployment/windows/jellyfin.nsi (+122 -18)

📄 Description

Changes
Significant updates and changes to the NSIS Installer for Windows. Most are centered around non-service installs.

Current Functions

Adds a new dialog for "Setup Type", with choices of Basic or Advanced
On choosing Basic install, skips component page and service config
During basic install, if it exists, uses config from %AppDataLocal% directory
During basic install, creates desktop/start menu shortcuts with icon file from UX
During uninstall, remove shortcuts
During upgrade, skip component page if setup type is basic
During upgrade, recreate shortcuts
During upgrade, use whatever data dir folder exists if setup type is basic
Sets parameters on shortcuts to use the correct datadir
Ensure that shortcuts are only created during upgrade if setup type is basic
Set NSSM to exit if service start fails (instead of infinitely retrying like now)
Integrates Tray App

To Do

~~Comment, lint, and re-organize install script file~~ This will have to come later

Issues
Kind of #1836, and other posts on Reddit, etc.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/1903 **Author:** [@anthonylavado](https://github.com/anthonylavado) **Created:** 10/16/2019 **Status:** ✅ Merged **Merged:** 11/3/2019 **Merged by:** [@joshuaboniface](https://github.com/joshuaboniface) **Base:** `master` ← **Head:** `nsis-update` --- ### 📝 Commits (10+) - [`c8ffa2f`](https://github.com/jellyfin/jellyfin/commit/c8ffa2fb1d2c56306fa9bca19d73c9842ba5b0b4) Set service install default to no - [`04c4ad7`](https://github.com/jellyfin/jellyfin/commit/04c4ad731e36fc36d5e924cc7adf0e12f25cf1b5) Begin to add setup type dialog - [`05fb84b`](https://github.com/jellyfin/jellyfin/commit/05fb84ba2236b0fd0727caf29fad4986059c8b8e) Make service setup an optional component, remove setuptype page config for now - [`9ad7813`](https://github.com/jellyfin/jellyfin/commit/9ad781324ebdfb9679a0dcf4258195a870c0826c) Fix up Setup Type dialog, and add logic for basic setup - [`f80343b`](https://github.com/jellyfin/jellyfin/commit/f80343bf9dfa6d79df85b12cdd66d3602c269ebc) Fix the Setup Type dialog titles - [`dc46620`](https://github.com/jellyfin/jellyfin/commit/dc46620a81e65d63acf485e2bae5f1462772582a) Automatically creates shortcuts for non-service installs - [`5232302`](https://github.com/jellyfin/jellyfin/commit/52323025321162c7013012a42490c5d85d0d5154) Adds icons to shortcuts, fixes nsis warning - [`63e0bd1`](https://github.com/jellyfin/jellyfin/commit/63e0bd1d619f3121918ce784f5c2b000a8eebf23) Only create/remove shortcuts on non-service install - [`6f504a2`](https://github.com/jellyfin/jellyfin/commit/6f504a246b27865a36fc82cee3d1af47f99a57ed) Use the registry path for datadir, don't override it here - [`330395e`](https://github.com/jellyfin/jellyfin/commit/330395e8b63f46ce9d5ca89fa72f49ff860b5795) Check for the presence of AppDataLocal folder before using it ### 📊 Changes **5 files changed** (+207 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `.ci/azure-pipelines.yml` (+1 -1) 📝 `deployment/windows/build-jellyfin.ps1` (+22 -0) ➕ `deployment/windows/dialogs/setuptype.nsddef` (+12 -0) ➕ `deployment/windows/dialogs/setuptype.nsdinc` (+50 -0) 📝 `deployment/windows/jellyfin.nsi` (+122 -18) </details> ### 📄 Description **Changes** Significant updates and changes to the NSIS Installer for Windows. Most are centered around non-service installs. **Current Functions** * Adds a new dialog for "Setup Type", with choices of Basic or Advanced * On choosing Basic install, skips component page and service config * During basic install, if it exists, uses config from %AppDataLocal% directory * During basic install, creates desktop/start menu shortcuts with icon file from UX * During uninstall, remove shortcuts * During upgrade, skip component page if setup type is basic * During upgrade, recreate shortcuts * During upgrade, use whatever data dir folder exists if setup type is basic * Sets parameters on shortcuts to use the correct datadir * Ensure that shortcuts are only created during upgrade if setup type is basic * Set NSSM to exit if service start fails (instead of infinitely retrying like now) * Integrates Tray App **To Do** * ~~Comment, lint, and re-organize install script file~~ This will have to come later **Issues** Kind of #1836, and other posts on Reddit, etc. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 07:06:26 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 08:53:04 +01:00

[PR #8763] [CLOSED] It92019 ana marija #11669

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#8763

No description provided.

Rows
Columns