[PR #1692] [MERGED] NSIS improvements #8677

New issue

Closed

opened 2025-12-22 07:02:52 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 07:02:52 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/1692
Author: @EraYaN
Created: 8/31/2019
Status: ✅ Merged
Merged: 9/9/2019
Merged by: @anthonylavado

Base: master ← Head: nsis-installer-updates

📝 Commits (3)

b2e4682 Much better, but still broken
9779a6f Fixed the problems and finished the NSIS installer.
e243e52 Added changes to CI for setup building.

📊 Changes

13 files changed (+650 additions, -295 deletions)

View changed files

📝 .ci/azure-pipelines.yml (+50 -22)
📝 .gitignore (+4 -0)
📝 deployment/windows/build-jellyfin.ps1 (+57 -31)
📝 deployment/windows/dependencies.txt (+1 -0)
➕ deployment/windows/dialogs/confirmation.nsddef (+24 -0)
➕ deployment/windows/dialogs/confirmation.nsdinc (+61 -0)
➕ deployment/windows/dialogs/service-config.nsddef (+13 -0)
➕ deployment/windows/dialogs/service-config.nsdinc (+56 -0)
➕ deployment/windows/helpers/ShowError.nsh (+10 -0)
➕ deployment/windows/helpers/StrSlash.nsh (+47 -0)
📝 deployment/windows/jellyfin.nsi (+327 -242)
📝 deployment/windows/legacy/install-jellyfin.ps1 (+0 -0)
📝 deployment/windows/legacy/install.bat (+0 -0)

📄 Description

Changes
Split out config options into separate steps, instead of sections, added images, more robust service upgrading and account management (win10 service account can be added)

Use command (first time): .\deployment\windows\build-jellyfin.ps1 -InstallFFMPEG -InstallNSSM -MakeNSIS
This does no longer downloads NSIS, assumes it's in the path.
Use command (later): .\deployment\windows\build-jellyfin.ps1 -MakeNSIS -SkipJellyfinBuild

This assumes jellyfin-ux with my PR checkouts next to the main repo, this is configurable.

I have an example setup, but it's too large for GitHub. EDIT: https://dev.azure.com/jellyfin-project/jellyfin/_build/results?buildId=707&view=results (download it there)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/1692 **Author:** [@EraYaN](https://github.com/EraYaN) **Created:** 8/31/2019 **Status:** ✅ Merged **Merged:** 9/9/2019 **Merged by:** [@anthonylavado](https://github.com/anthonylavado) **Base:** `master` ← **Head:** `nsis-installer-updates` --- ### 📝 Commits (3) - [`b2e4682`](https://github.com/jellyfin/jellyfin/commit/b2e468260e88d5841ccfcc7f216d4fdd7e19ffde) Much better, but still broken - [`9779a6f`](https://github.com/jellyfin/jellyfin/commit/9779a6f1d1ead50696a012ba578fb51f3609a047) Fixed the problems and finished the NSIS installer. - [`e243e52`](https://github.com/jellyfin/jellyfin/commit/e243e52a9b2b19d401c371a5aac6557a7907ee09) Added changes to CI for setup building. ### 📊 Changes **13 files changed** (+650 additions, -295 deletions) <details> <summary>View changed files</summary> 📝 `.ci/azure-pipelines.yml` (+50 -22) 📝 `.gitignore` (+4 -0) 📝 `deployment/windows/build-jellyfin.ps1` (+57 -31) 📝 `deployment/windows/dependencies.txt` (+1 -0) ➕ `deployment/windows/dialogs/confirmation.nsddef` (+24 -0) ➕ `deployment/windows/dialogs/confirmation.nsdinc` (+61 -0) ➕ `deployment/windows/dialogs/service-config.nsddef` (+13 -0) ➕ `deployment/windows/dialogs/service-config.nsdinc` (+56 -0) ➕ `deployment/windows/helpers/ShowError.nsh` (+10 -0) ➕ `deployment/windows/helpers/StrSlash.nsh` (+47 -0) 📝 `deployment/windows/jellyfin.nsi` (+327 -242) 📝 `deployment/windows/legacy/install-jellyfin.ps1` (+0 -0) 📝 `deployment/windows/legacy/install.bat` (+0 -0) </details> ### 📄 Description **Changes** Split out config options into separate steps, instead of sections, added images, more robust service upgrading and account management (win10 service account can be added) Use command (first time): `.\deployment\windows\build-jellyfin.ps1 -InstallFFMPEG -InstallNSSM -MakeNSIS` This does no longer downloads NSIS, assumes it's in the path. Use command (later): `.\deployment\windows\build-jellyfin.ps1 -MakeNSIS -SkipJellyfinBuild` This assumes `jellyfin-ux` with my PR checkouts next to the main repo, this is configurable. I have an example setup, but it's too large for GitHub. EDIT: https://dev.azure.com/jellyfin-project/jellyfin/_build/results?buildId=707&view=results (download it there) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 07:02:52 +01:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#8677

No description provided.

Rows
Columns