[PR #1137] [MERGED] Fix default value for Expires header #8488

New issue

Closed

opened 2025-12-22 06:55:17 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 06:55:17 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/1137
Author: @thornbill
Created: 3/20/2019
Status: ✅ Merged
Merged: 3/24/2019
Merged by: @Bond-009

Base: master ← Head: fix-expires-header

📝 Commits (1)

4cd8903 Fix default value for Expires header

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 Emby.Server.Implementations/HttpServer/HttpResultFactory.cs (+4 -4)

📄 Description

Changes
Changes the default value of the Expires HTTP header to be "0" instead of "-1". The RFC specifically mentions using "0" to represent values that have already expired.

The Java apiclient uses Gson for serializing the response and it logs warnings for the use of "-1".

Issues
N/A

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/1137 **Author:** [@thornbill](https://github.com/thornbill) **Created:** 3/20/2019 **Status:** ✅ Merged **Merged:** 3/24/2019 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `fix-expires-header` --- ### 📝 Commits (1) - [`4cd8903`](https://github.com/jellyfin/jellyfin/commit/4cd8903abc1e0c19d717e2930382c37836706e88) Fix default value for Expires header ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/HttpServer/HttpResultFactory.cs` (+4 -4) </details> ### 📄 Description **Changes** Changes the default value of the `Expires` HTTP header to be `"0"` instead of `"-1"`. The [RFC](https://tools.ietf.org/html/rfc7234#section-5.3) specifically mentions using `"0"` to represent values that have already expired. The Java apiclient uses Gson for serializing the response and it logs warnings for the use of `"-1"`. **Issues** N/A --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 06:55:17 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 08:49:19 +01:00

[PR #8488] [MERGED] Bump actions/setup-dotnet from 2 to 3 #11549

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#8488

No description provided.

Rows
Columns