mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-23 23:20:51 +01:00
Influence of different localisation settings on Audio/Subtitle track selector #6123
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#6123
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jmercz on GitHub (Jul 15, 2024).
Please describe your bug
This issue is based on the closing recommendation of issue #12272 to split the described problems into separate issues, namely recommendation 2 and 3. I decided to combine these two recommendations into one issue, as I lack the knowledge of the backend and cannot reasonably decompose the problems further, but can only describe my observations. Feel free to have a look into said issue, as it might give a better complete picture of the problems in the track selector.
This issue focuses on the influence of different localisation settings that can be made on the user side and the server side. The main issue is, that as a user I would expect the audio and subtitle track selection to be localised based on the user localisation setting. The resulting strings in the selector are however mainly influenced by several server settings, that may be inaccessible to said user.
Reproduction Steps
The following example uses German as the language for localisation. However this should be reproducable with any other language.
Starting from an all English setup with the following GUI options:
and the following environment variables set for the Docker container:
the track selector looks like:

Now we will gradually change to a German localisation by changing several settings and see the outcome.
User setting: Display language
Changing the user display language under User > Settings > Display > Display language to German yields

Only the labels for the categories are localised ("Subtitle" -> "Untertitel"). However, the string of the selector itself remains untouched.
Server setting: Preferred display language
Changing the preferred server display language under Administration > Dashboard > General > Preferred display language to German yields

localising only the default flag of the string in the track selector ("Default" -> "Standard"). (Though only for the subtitle track, refer to issue #12276).
Server environment: Environment variables
Only when we change the environment variables of the server itself - which I consider even a level above the server settings you can set in Jellyfin's GUI - to
the strings in the selector are fully localised:

where the language flags are successfully localised ("German" -> "Deutsch").
Summary
As @felix920506 suggested in his closing recommendation of #12272, the selector should be made into a client string, instead of a server string for better localisation support. On that note, I would propose that the localisation of the track selection should be controlled by only one setting, namely the user display language, since it is a crucial item of GUI interaction with the user. Furthermore, it is the only setting a restricted user can set by itself, without any admin rights.
Jellyfin Version
10.9.0
if other:
No response
Environment
Jellyfin logs
FFmpeg logs
No response
Please attach any browser or client logs here
No response
Please attach any screenshots here
No response
Code of Conduct
@jellyfin-bot commented on GitHub (Jul 15, 2024):
Hi, it seems like your issue report has the following item(s) that need to be addressed:
This is an automated message, currently under testing. Please file an issue here if you encounter any problems.