starred/jellyfin

Fork 0

mirror of https://github.com/jellyfin/jellyfin.git synced 2026-01-23 23:20:51 +01:00

[Issue]: OS name endpoint was removed and the VPP tonemap options disappears #5614

New issue

Closed

opened 2025-12-22 02:05:13 +01:00 by backuprepo · 1 comment

backuprepo commented

2025-12-22 02:05:13 +01:00

Owner

Originally created by @nyanmisaka on GitHub (Apr 18, 2024).

Please describe your bug

The OS name endpoint was removed in #9175 since it was considered useless, but the VPP tonemap options in the web client relies on this to choose to display on Linux and hide on Windows.

        if (systemInfo.OperatingSystem.toLowerCase() === 'linux' && (this.value == 'qsv' || this.value == 'vaapi')) {
            page.querySelector('.vppTonemappingOptions').classList.remove('hide');
        } else {
            page.querySelector('.vppTonemappingOptions').classList.add('hide');
        }

In the future, cross-platform Vulkan and VA-API HWA may also need OS name to display the corresponding web options. So I'm not sure if it's necessary to revert this change.

Reproduction Steps

In Jellyfin server Linux/Docker builds
Go to Dashboard -> Playback
Select Intel QuickSync HWA
You can see the VPP tonemap options are missing

Jellyfin Version

Unstable (master branch)

if other:

No response

Environment

- OS: Linux
- Linux Kernel: Any
- Virtualization: None and Docker
- Clients: Web client
- Browser: Any
- FFmpeg Version: Not used
- Playback Method: Not used
- Hardware Acceleration: Not used
- GPU Model: Not used
- Plugins: Not used
- Reverse Proxy: Not used
- Base URL: Not used
- Networking: Localhost
- Storage: Local

Jellyfin logs

This error is not shown in the server log

FFmpeg logs

This error is not shown in the ffmpeg log

Please attach any browser or client logs here

This error is not shown in the browser log

Please attach any screenshots here

Code of Conduct

I agree to follow this project's Code of Conduct

Originally created by @nyanmisaka on GitHub (Apr 18, 2024). ### Please describe your bug The OS name endpoint was removed in [#9175](https://github.com/jellyfin/jellyfin/pull/9175) since it was considered useless, but the VPP tonemap options in the [web client relies on this](https://github.com/jellyfin/jellyfin-web/blob/17b1a757ddcfd317f34881628c7ca79b14481db7/src/controllers/dashboard/encodingsettings.js#L234) to choose to display on Linux and hide on Windows. ```js if (systemInfo.OperatingSystem.toLowerCase() === 'linux' && (this.value == 'qsv' || this.value == 'vaapi')) { page.querySelector('.vppTonemappingOptions').classList.remove('hide'); } else { page.querySelector('.vppTonemappingOptions').classList.add('hide'); } ``` In the future, cross-platform Vulkan and VA-API HWA may also need OS name to display the corresponding web options. So I'm not sure if it's necessary to revert this change. ### Reproduction Steps 1. In Jellyfin server Linux/Docker builds 2. Go to Dashboard -> Playback 3. Select Intel QuickSync HWA 4. You can see the VPP tonemap options are missing ### Jellyfin Version Unstable (master branch) ### if other: _No response_ ### Environment ```markdown - OS: Linux - Linux Kernel: Any - Virtualization: None and Docker - Clients: Web client - Browser: Any - FFmpeg Version: Not used - Playback Method: Not used - Hardware Acceleration: Not used - GPU Model: Not used - Plugins: Not used - Reverse Proxy: Not used - Base URL: Not used - Networking: Localhost - Storage: Local ``` ### Jellyfin logs ```shell This error is not shown in the server log ``` ### FFmpeg logs ```shell This error is not shown in the ffmpeg log ``` ### Please attach any browser or client logs here This error is not shown in the browser log ### Please attach any screenshots here ![image](https://github.com/jellyfin/jellyfin/assets/14953024/b9c9e29c-aba5-4ec4-a016-8d8f1f894fc0) ### Code of Conduct - [X] I agree to follow this project's Code of Conduct

backuprepo

2025-12-22 02:05:13 +01:00

closed this issue
added the
confirmed

bug
labels

backuprepo commented

2025-12-22 02:05:16 +01:00

Author

Owner

@jellyfin-bot commented on GitHub (Apr 18, 2024):

Hi, it seems like your issue report has the following item(s) that need to be addressed:

You have not provided the ffmpeg log unaltered from the server. Please provide a valid ffmpeg log.

This is an automated message, currently under testing. Please file an issue here if you encounter any problems.

@jellyfin-bot commented on GitHub (Apr 18, 2024): Hi, it seems like your issue report has the following item(s) that need to be addressed: - You have not provided the ffmpeg log unaltered from the server. Please provide a valid ffmpeg log. This is an automated message, currently under testing. Please file an issue [here](https://github.com/jellyfin/jellyfin-triage-scripts/issues) if you encounter any problems.

backuprepo referenced this issue

2025-12-22 08:01:45 +01:00

[PR #5614] [MERGED] Fix possible null ref exception #10396

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#5614

No description provided.

Rows
Columns