mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-23 23:20:51 +01:00
[Issue]: Studio Images plugin comes with default URL that 404's #5216
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#5216
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mihawk90 on GitHub (Nov 6, 2023).
Please describe your bug
I just stumbled on this but I'm not sure this is the right repo, however I also couldn't find a separate repository for the Studio Images plugin, so here goes.
The Studio Images default plugin comes with a default URL:
https://raw.github.com/jellyfin/emby-artwork/master/studioshowever, as you can tell when trying to open this, it just returns404: Not FoundThat subdomain has been redirecting to
raw.githubusercontent.comfor a while, e.g.: https://raw.githubusercontent.com/jellyfin/emby-artwork/master/studios/thumbs.txtI don't believe it is planned to terminate the old subdomain, however I do believe it is a good idea to keep URLs current, if nothing else to avoid unnecessary DNS roundtrips.
Now, going to
https://raw.githubusercontent.com/jellyfin/emby-artwork/master/studios/returns a400: Invalid request, however I assume this base-url is never called directly, but rather the files inside them so it would be fine.On a side note: The hint shown on the field says "This can be any Jellyfin-compatible artwork repository. Leave blank to use default repository.", but, well... this field is filled by default, so why not just leave it blank for the default repository?
I noticed that when I delete the value and save, go back to plugins and back into the Plugin settings, it stays empty. However the field is filled in again after a restart of Jellyfin. Now I'm wondering what happens if the URL ever changes? Since the field is filled it would take precedence over the default, no?
Jellyfin Version
10.8.z
if other:
10.8.11
Environment
Jellyfin logs
No response
FFmpeg logs
No response
Please attach any browser or client logs here
No response
Please attach any screenshots here
No response
Code of Conduct
@mihawk90 commented on GitHub (Nov 8, 2023):
Had some time and dug a little...
Seems this is the correct repo:
c2bfa17fcb/MediaBrowser.Providers/Plugins/StudioImages/Plugin.cs (L21)@jellyfin-bot commented on GitHub (Mar 8, 2024):
This issue has gone 120 days without an update and will be closed within 21 days if there is no new activity. To prevent this issue from being closed, please confirm the issue has not already been fixed by providing updated examples or logs.
If you have any questions you can use one of several ways to contact us.
@adripo commented on GitHub (Mar 8, 2024):
Is it possible to use the api endpoint to retrieve the files?
example:
https://api.github.com/repos/jellyfin/emby-artwork/contents/studios@mihawk90 commented on GitHub (Mar 8, 2024):
Also just wanted to add, yes it's unchanged.