starred/jellyfin

Fork 0

mirror of https://github.com/jellyfin/jellyfin.git synced 2026-01-23 23:20:51 +01:00

Add "speed" property to playback state API's #4456

New issue

Open

opened 2025-12-22 00:05:42 +01:00 by backuprepo · 8 comments

backuprepo commented

2025-12-22 00:05:42 +01:00

Owner

Originally created by @nielsvanvelzen on GitHub (Dec 28, 2022).

Currently, the remote control API does not support a "speed" property. We should add it to the API so we can:

interpolate the current progress without sending a playback update 10 times per second
view the playback speed in dashboard/remote control
allow for changing the speed using remote control

The property should be a float/double with a default value of 1.0. The server should clamp the value to avoid bad input (something like 0.1-10.0?).

From my understanding the new property should be added to (at least) PlaybackProgressInfo, PlaybackStartInfo and PlayerStateInfo. And likely more.

Originally created by @nielsvanvelzen on GitHub (Dec 28, 2022). Currently, the remote control API does not support a "speed" property. We should add it to the API so we can: 1) interpolate the current progress without sending a playback update 10 times per second 2) view the playback speed in dashboard/remote control 3) allow for changing the speed using remote control The property should be a float/double with a default value of 1.0. The server should clamp the value to avoid bad input (something like 0.1-10.0?). From my understanding the new property should be added to (at least) PlaybackProgressInfo, PlaybackStartInfo and PlayerStateInfo. And likely more.

backuprepo added the

good first issue

enhancement

labels 2025-12-22 00:05:42 +01:00

backuprepo commented

2025-12-22 00:05:44 +01:00

Author

Owner

@crobibero commented on GitHub (Jan 31, 2023):

What happens in the kotlin sdk if we add a new, non-nullable propety to an object? I thought doing so broke existing versions

@crobibero commented on GitHub (Jan 31, 2023): What happens in the kotlin sdk if we add a new, non-nullable propety to an object? I thought doing so broke existing versions

backuprepo commented

2025-12-22 00:05:46 +01:00

Author

Owner

@nielsvanvelzen commented on GitHub (Jan 31, 2023):

If no default value is set: In a query parameter it will give a compile error, in a response it will give a runtime error when using an older API version. With a default value it will automatically fallback to that value and no changes in the client are required.

So we can set the default value for speed to 1.0 to avoid breaking API changes.

@nielsvanvelzen commented on GitHub (Jan 31, 2023): If no default value is set: In a query parameter it will give a compile error, in a response it will give a runtime error when using an older API version. With a default value it will automatically fallback to that value and no changes in the client are required. So we can set the default value for speed to `1.0` to avoid breaking API changes.

backuprepo commented

2025-12-22 00:05:49 +01:00

Author

Owner

@rzk3 commented on GitHub (Feb 16, 2023):

Hi! I'd like to take on this issue!

@rzk3 commented on GitHub (Feb 16, 2023): Hi! I'd like to take on this issue!

backuprepo commented

2025-12-22 00:05:50 +01:00

Author

Owner

@Bogdanf21 commented on GitHub (Aug 2, 2023):

Hi, is anyone currently working on this?

@Bogdanf21 commented on GitHub (Aug 2, 2023): Hi, is anyone currently working on this?

backuprepo commented

2025-12-22 00:05:53 +01:00

Author

Owner

@pmnlla commented on GitHub (Aug 3, 2023):

Waiting to merge #9329 iirc

@pmnlla commented on GitHub (Aug 3, 2023): Waiting to merge #9329 iirc

backuprepo commented

2025-12-22 00:05:54 +01:00

Author

Owner

@singlatushar07 commented on GitHub (Jun 17, 2024):

Hi, is this still being worked on? If not, I would like to work on this.

@singlatushar07 commented on GitHub (Jun 17, 2024): Hi, is this still being worked on? If not, I would like to work on this.

backuprepo commented

2025-12-22 00:05:54 +01:00

Author

Owner

@Jeeva7RP-DevEng commented on GitHub (Mar 3, 2025):

Hi, is this issue fixed? If not, I would like to work on this.

@Jeeva7RP-DevEng commented on GitHub (Mar 3, 2025): Hi, is this issue fixed? If not, I would like to work on this.

backuprepo commented

2025-12-22 00:05:56 +01:00

Author

Owner

@LezardSC commented on GitHub (Nov 28, 2025):

Hi, I feel like no one is working on it anymore. If no one answered that they're working on it at December 1st I'll start working on it.

EDIT: I noticed that PR https://github.com/jellyfin/jellyfin/pull/9329 implements most of this but isn't merged.
I don't know why but I will not work on it since the work is already done.

@LezardSC commented on GitHub (Nov 28, 2025): Hi, I feel like no one is working on it anymore. If no one answered that they're working on it at December 1st I'll start working on it. EDIT: I noticed that PR https://github.com/jellyfin/jellyfin/pull/9329 implements most of this but isn't merged. I don't know why but I will not work on it since the work is already done.

backuprepo referenced this issue

2025-12-22 07:44:31 +01:00

[PR #4456] [MERGED] Emby.Naming - nullable & code coverage #9909

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#4456

No description provided.

Rows
Columns