mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-24 07:30:57 +01:00
Filter videos by audio stream language #295
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#295
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @taconaut on GitHub (Jan 18, 2019).
Describe the feature you'd like
Add the ability to filter by available audio stream language for videos
Additional context
I'd like to be able to filter video streams (movies, series) by available audio language
I will work on this to get a hands on with the Jellyfin code. I'm checking the filtering by Genre implementation, which has to be very similar.
TODO:
@dkanada commented on GitHub (Jan 24, 2019):
See here for an API call to get localization labels for languages.
@taconaut commented on GitHub (Jan 24, 2019):
Thanks @daknin, I've got most of the implementation, but as js in not my speciality, I've still got some issues. I should have it ready by the weekend.
As I couldn't find any json containing key=code, value=language, I've written a little scraper outputting the wanted json here https://github.com/taconaut/ISO639ToJson. See bottom of README for the two possible outputs; I intend to use the native one.
[edit] actually I've planned to add the json to the frontend strings. Do you think it should be exposed by the backend?
@JustAMan commented on GitHub (Jan 24, 2019):
I think it should be enough for now to stuff in frontend, but I might be wrong here.
@taconaut commented on GitHub (Jan 24, 2019):
Both can be right.
My reasoning to put it in the frontend was that the backend only needs the codes to do what it has to do and the language names are only there for the end user.
A counter argument would be that there are many clients (web, smart TVs, mobile apps...) which will all have to have their own implementation and might not be coherent. This can be a benefit as well, if one wants to fully localize the names for each language, the other wants to show native names and the third one English.
If adding it to the backend I wouldn't have exposed resources, but included the language names directly as key/values in the get filters query.
@jellyfin-bot commented on GitHub (Jul 29, 2019):
We are moving all feature and enhancement requests to our new Fider platform here. This new platform lets people vote on and better manage such requests.
This request now lives here.