mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-24 07:30:57 +01:00
Remove Premiere and Connect references? #24
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#24
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @anthonylavado on GitHub (Dec 11, 2018).
In various spots, there are references to Premiere and Connect. Some of these were just links for more info (see #32 where I changed some of these).
We should look at how we can effectively “remove” these entries/links from the UI, so users don’t encounter them.
I imagine the underlying code can be left as is for now (if there’s no way to call it, is it really there?). That way if we opt to rebuild connect somehow, we have somewhere to start from.
@JustAMan commented on GitHub (Dec 11, 2018):
I vote for complete removal. I can not imagine the need for re-implementing Connect if we never plan to do paid features... and I rather we do not. Paid support is fine, though, if someone asks.
@ajdunevent commented on GitHub (Dec 11, 2018):
I have a lifetime Emby Premiere subscription which I got at the beginning of 2016 when the project was, as far as I knew, fully open source and, I think, before the nag screens and moving of important features to paid only (offtopic: imagine how irritated I am about their license bait-and-switch). Though I have no right to weigh in on this topic as I'm not even remotely a developer, I also vote for complete removal. If something like Premiere is left in, it should only unlock at most very minor, optional features (like a "Thanks for your support" badge and, I don't know, maybe an alternative color theme). And, most importantly, the developers should be willing to accept without grief that their open source project might be forked to allow those very minor, optional features without payment.
@joshuaboniface commented on GitHub (Dec 11, 2018):
@JustAMan I firmly said as much on Reddit, so definitely - let's just strip it all out.
I already hid the badge on the Admin Dashboard page.
@napcae commented on GitHub (Jan 10, 2019):
Information: This issue is being worked on in PR 412. Referencing here so this issues gets closed when the PR gets merged.
@JustAMan commented on GitHub (Jan 23, 2019):
Should be fixed by #412
@anthonylavado commented on GitHub (Jan 23, 2019):
I can agree on this. Closing.