mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-24 07:30:57 +01:00
[Docker] Default ffmpeg path is not being displayed #223
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#223
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @LeoVerto on GitHub (Jan 7, 2019).
When starting jellyfin from docker with an empty config dir the ffmpeg binary path is empty whereas it should default to
/usr/bin/ffmpeg.@sparky8251 commented on GitHub (Jan 7, 2019):
Correct me if I'm wrong but this is just a display bug yes? FFMPEG has worked for me despite that box being empty before.
If so, it might be fixed by #412 and it definitely belongs as part of #122.
@cvium commented on GitHub (Jan 7, 2019):
Where is it shown? If it's Settings -> Transcoding, then it is not fixed by #412. I'm not even sure it's a bug.
@louisefindlay23 commented on GitHub (Jan 13, 2019):
It makes transcoding fail for me until I set it.
@sparky8251 commented on GitHub (Jan 13, 2019):
That's new... Got logs of it failing? Might have to look in
docker logsas well as the normal Jellyfin logs.@louisefindlay23 commented on GitHub (Jan 13, 2019):
This is the docker logs - not sure where jellyfin logs are -
log.txt
@hawken93 commented on GitHub (Jan 13, 2019):
For next time, this would be easier to read if attached as a file:)
@andrewrabert commented on GitHub (Jan 13, 2019):
Changed a comment to have the log in an attachment.
@ploughpuff commented on GitHub (Feb 7, 2019):
Question for UI devs please. Is it possible to write directly into field txtEncoderPath (src/encodingsettings.html, src/scripts/encodingssettings.js) from a method in class MediaEncoder? If so, how please?
I've worked on improving the FFmpeg path discovery and this is the final missing link to resolving this issue. I need to update that input textbox without writing to the config/encoding.xml file. Then we can display the FQPN to the encoder but it wouldn't be remember for next start (unless user clicks save! of course)..
@ploughpuff commented on GitHub (Feb 8, 2019):
So writing directly to .txtEncoderPath is a no go, and probably the wrong approach anyway.
What we can do is always write the current FFmpeg path to the xml so it is displayed to the user. That will fix this issue but presents another.. On restart, if CLI switch --ffmpeg is given, or for whatever reason the Custom path becomes unavailable, then the users Custom path in xml would be lost and over-written with a System $PATH. Not ideal, but is solved by creating a new entry in the xml specifically to record the Custom user entered setting. We therefore need two entries in the xml: 1) only gets set from the Transcode page (via user update/submit), 2) String to reflect the current path to FFmpeg being used.
I've put a change-set together and shall raise a PR soon for people to review.
@mkeguy106 commented on GitHub (Feb 24, 2019):
Fresh docker install today, first time jellyfin user. Videos wouldn't play. Had to set transcoding ffmpeg path in UI. Its also not located in /usr/bin, but in /usr/local/bin/ffmpeg. Once I set that playback worked just fine.