mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-23 23:20:51 +01:00
Regression on 10.6: Media files under a subtree of a hidden directory are excluded from the library scan #1933
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#1933
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @faik-dev on GitHub (Jul 24, 2020).
Describe the bug
On version 10.6.0, the contents of the folders that are added to the library are not scanned if the folder itself or any of its parent tree is a hidden directory.
Example: A path like
/opt/.libraryor/opt/.library/some-dircontent won't be scanned, as opposed to a directory like/opt/library.This causes part of the library to disappear after upgrading to 10.6.
System (please complete the following information):
To Reproduce
/opt/.a/opt/.b/x/opt/c(Follow the same steps on version 10.5.5 to see that all libraries are scanned correctly)
Expected behavior
The files under hidden directories are also scanned and added to the library.
@Shadowghost commented on GitHub (Jul 24, 2020):
If this ever woked it shouldn't have at all.
Directories starting with
.or with a.ignorefile within them will be omitted on scan. We inherited this behaviour.@faik-dev commented on GitHub (Jul 24, 2020):
I see. Still I think this might count as a regression, because it results in media disappearing from users' libraries after the upgrade.
Maybe adding a feature to optionally include hidden directories via a checkbox like "Include hidden directories" on library settings is a good idea, so that users can enable it to bring their media back without moving files on the filesystem.
If you'd agree, I can create a feature request for it (not sure if I could find time to implement it though).
@aaruni96 commented on GitHub (Jul 25, 2020):
I think this also explains my issue https://github.com/jellyfin/jellyfin/issues/3651 .
Everything which disappeared was under a dot directory.
/media/aaruni/externalHDD/.jellyfin/TV/@faik-dev commented on GitHub (Jul 25, 2020):
Tbh I think this need fixing, because it seems like using hidden folders was a common use case.
Especially considering the fact that it does not only ignore the hidden directories in the subtree, it also ignores the files if one of the directories in the parent tree is hidden.
Example:
If we define
/opt/.a/b/as a library folder, it won't only exclude, say/opt/.a/b/.c, it will exclude everything, including/opt/.a/b/d,/opt/.a/b/eand so on - because there's.ain the parent tree.Imo Jellyfin should at least be agnostic to the parent directory tree - it has nothing to do with it.
@oddstr13 commented on GitHub (Jul 25, 2020):
This is caused by #3099 (
**/.*/**)While the pattern added in #3456 is similar (
**/.*), it is most likely fine to ignore all dotfiles. If not, mac specific ignores need to be added.@aaruni96 commented on GitHub (Jul 26, 2020):
Temporary workaround : symlink a file structure without dotfolders to media location.
/home/jellyfin/usb/TV -> /media/usb/.jellyfin/TV
@TKFRvisionOfficial commented on GitHub (Feb 9, 2021):
This issue is back on 10.7.0 rc3...
@crobibero commented on GitHub (Feb 9, 2021):
This was already reported and fixed in a different issue. https://github.com/jellyfin/jellyfin/issues/5135