[PR #15650] .NET 10 including build issues #14195

Open
opened 2025-12-22 10:22:14 +01:00 by backuprepo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15650
Author: @TekuSP
Created: 11/27/2025
Status: 🔄 Open

Base: masterHead: net10


📝 Commits (9)

  • a6215a6 Update to .NET 10.0
  • 4456e1e Fix tests
  • c3ef47e Replace AlphanumericComparator with new CompareOptions.NumericOrdering
  • 7643a9f Merge remote-tracking branch 'JellyFin/master' into net10
  • 24865d5 Fix logger CA2024: Do not use StreamReader.EndOfStream in async methods
  • bba524e Fix nullable annotation
  • 439a08d Fix error CA1849: 'ZipFile.ExtractToDirectory(Stream, string, bool)' synchronously blocks. Await 'ZipFile.ExtractToDirectoryAsync(Stream, string, bool, CancellationToken)' instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849)
  • cf75eee Fix error CA2016: Forward the 'cancellationToken' parameter to the 'ExtractToDirectoryAsync' method or pass in 'CancellationToken.None' explicitly to indicate intentionally not propagating the token
  • e207385 Update Actions to .NET 10

📊 Changes

60 files changed (+154 additions, -332 deletions)

View changed files

📝 .editorconfig (+7 -0)
📝 .github/workflows/ci-codeql-analysis.yml (+1 -1)
📝 .github/workflows/ci-compat.yml (+2 -2)
📝 .github/workflows/ci-openapi.yml (+4 -4)
📝 .github/workflows/ci-tests.yml (+1 -1)
📝 .vscode/launch.json (+3 -3)
📝 Directory.Packages.props (+20 -29)
📝 Emby.Naming/Emby.Naming.csproj (+1 -1)
📝 Emby.Naming/Video/VideoListResolver.cs (+13 -4)
📝 Emby.Photos/Emby.Photos.csproj (+1 -1)
📝 Emby.Server.Implementations/Emby.Server.Implementations.csproj (+1 -2)
📝 Emby.Server.Implementations/Sorting/StudioComparer.cs (+2 -2)
📝 Emby.Server.Implementations/Updates/InstallationManager.cs (+1 -1)
📝 Jellyfin.Api/Helpers/HlsHelpers.cs (+2 -8)
📝 Jellyfin.Api/Jellyfin.Api.csproj (+1 -1)
📝 Jellyfin.Data/Jellyfin.Data.csproj (+1 -1)
📝 Jellyfin.Server.Implementations/FullSystemBackup/BackupService.cs (+8 -7)
📝 Jellyfin.Server.Implementations/Jellyfin.Server.Implementations.csproj (+1 -2)
📝 Jellyfin.Server/Extensions/ApiServiceCollectionExtensions.cs (+4 -7)
📝 Jellyfin.Server/Jellyfin.Server.csproj (+1 -4)

...and 40 more files

📄 Description

Updated to .NET 10, fixed Actions, fixed warnings breaking compilation.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15650 **Author:** [@TekuSP](https://github.com/TekuSP) **Created:** 11/27/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `net10` --- ### 📝 Commits (9) - [`a6215a6`](https://github.com/jellyfin/jellyfin/commit/a6215a6f48b306c9fb1dc7830be5817202b756d8) Update to .NET 10.0 - [`4456e1e`](https://github.com/jellyfin/jellyfin/commit/4456e1e1293234f9d279bde7b41cdbf5f6f8c43c) Fix tests - [`c3ef47e`](https://github.com/jellyfin/jellyfin/commit/c3ef47e16b6e12799e1cd8cc924f969d012f6104) Replace AlphanumericComparator with new CompareOptions.NumericOrdering - [`7643a9f`](https://github.com/jellyfin/jellyfin/commit/7643a9fee50f3cf3d29acd8ec08b8d846b6e5cf6) Merge remote-tracking branch 'JellyFin/master' into net10 - [`24865d5`](https://github.com/jellyfin/jellyfin/commit/24865d53efa9f98359218d07aead35f18787609c) Fix logger CA2024: Do not use StreamReader.EndOfStream in async methods - [`bba524e`](https://github.com/jellyfin/jellyfin/commit/bba524ef7fa1a8060251ab71fac294a77e540326) Fix nullable annotation - [`439a08d`](https://github.com/jellyfin/jellyfin/commit/439a08d1af57ca58a1afa5c721f278804108d73f) Fix error CA1849: 'ZipFile.ExtractToDirectory(Stream, string, bool)' synchronously blocks. Await 'ZipFile.ExtractToDirectoryAsync(Stream, string, bool, CancellationToken)' instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849) - [`cf75eee`](https://github.com/jellyfin/jellyfin/commit/cf75eeeb03d414ca086a3b05df5f441b5919babe) Fix error CA2016: Forward the 'cancellationToken' parameter to the 'ExtractToDirectoryAsync' method or pass in 'CancellationToken.None' explicitly to indicate intentionally not propagating the token - [`e207385`](https://github.com/jellyfin/jellyfin/commit/e207385c0978a3becfb747d7bef0688a50378507) Update Actions to .NET 10 ### 📊 Changes **60 files changed** (+154 additions, -332 deletions) <details> <summary>View changed files</summary> 📝 `.editorconfig` (+7 -0) 📝 `.github/workflows/ci-codeql-analysis.yml` (+1 -1) 📝 `.github/workflows/ci-compat.yml` (+2 -2) 📝 `.github/workflows/ci-openapi.yml` (+4 -4) 📝 `.github/workflows/ci-tests.yml` (+1 -1) 📝 `.vscode/launch.json` (+3 -3) 📝 `Directory.Packages.props` (+20 -29) 📝 `Emby.Naming/Emby.Naming.csproj` (+1 -1) 📝 `Emby.Naming/Video/VideoListResolver.cs` (+13 -4) 📝 `Emby.Photos/Emby.Photos.csproj` (+1 -1) 📝 `Emby.Server.Implementations/Emby.Server.Implementations.csproj` (+1 -2) 📝 `Emby.Server.Implementations/Sorting/StudioComparer.cs` (+2 -2) 📝 `Emby.Server.Implementations/Updates/InstallationManager.cs` (+1 -1) 📝 `Jellyfin.Api/Helpers/HlsHelpers.cs` (+2 -8) 📝 `Jellyfin.Api/Jellyfin.Api.csproj` (+1 -1) 📝 `Jellyfin.Data/Jellyfin.Data.csproj` (+1 -1) 📝 `Jellyfin.Server.Implementations/FullSystemBackup/BackupService.cs` (+8 -7) 📝 `Jellyfin.Server.Implementations/Jellyfin.Server.Implementations.csproj` (+1 -2) 📝 `Jellyfin.Server/Extensions/ApiServiceCollectionExtensions.cs` (+4 -7) 📝 `Jellyfin.Server/Jellyfin.Server.csproj` (+1 -4) _...and 40 more files_ </details> ### 📄 Description Updated to .NET 10, fixed Actions, fixed warnings breaking compilation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
backuprepo added the
pull-request
label 2025-12-22 10:22:14 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#14195
No description provided.