[PR #15239] Normalize nuget includes in csproj, remove legacy ProductGuid #14085

New issue

Open

opened 2025-12-22 10:18:27 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 10:18:27 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/15239
Author: @crobibero
Created: 10/27/2025
Status: 🔄 Open

Base: master ← Head: csproj-normalize

📝 Commits (2)

fba8189 Normalize nuget includes in csproj, remove legacy ProductGuid
ac9baf5 A bit more cleanup

📊 Changes

27 files changed (+45 additions, -270 deletions)

View changed files

📝 Emby.Naming/Emby.Naming.csproj (+2 -27)
📝 Emby.Photos/Emby.Photos.csproj (+1 -6)
📝 Emby.Server.Implementations/Emby.Server.Implementations.csproj (+1 -6)
📝 Jellyfin.Api/Jellyfin.Api.csproj (+0 -5)
📝 Jellyfin.Data/Jellyfin.Data.csproj (+2 -19)
📝 Jellyfin.Server.Implementations/Jellyfin.Server.Implementations.csproj (+1 -1)
📝 Jellyfin.Server/Jellyfin.Server.csproj (+1 -6)
📝 MediaBrowser.Common/MediaBrowser.Common.csproj (+2 -27)
📝 MediaBrowser.Controller/MediaBrowser.Controller.csproj (+2 -27)
📝 MediaBrowser.LocalMetadata/MediaBrowser.LocalMetadata.csproj (+1 -6)
📝 MediaBrowser.MediaEncoding/MediaBrowser.MediaEncoding.csproj (+1 -6)
📝 MediaBrowser.Model/MediaBrowser.Model.csproj (+1 -26)
📝 MediaBrowser.Providers/MediaBrowser.Providers.csproj (+1 -6)
📝 MediaBrowser.XbmcMetadata/MediaBrowser.XbmcMetadata.csproj (+1 -6)
➕ Project.Nuget.targets (+21 -0)
📝 src/Jellyfin.Database/Jellyfin.Database.Implementations/Jellyfin.Database.Implementations.csproj (+2 -18)
📝 src/Jellyfin.Drawing.Skia/Jellyfin.Drawing.Skia.csproj (+0 -5)
📝 src/Jellyfin.Drawing/Jellyfin.Drawing.csproj (+0 -5)
📝 src/Jellyfin.Extensions/Jellyfin.Extensions.csproj (+3 -20)
📝 src/Jellyfin.MediaEncoding.Keyframes/Jellyfin.MediaEncoding.Keyframes.csproj (+2 -13)

...and 7 more files

📄 Description

Simplifies build automation

Edit- I went too far. We can simplify the nuget packages but I think moving GenerateAssemblyInfo broke this

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/15239 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 10/27/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `csproj-normalize` --- ### 📝 Commits (2) - [`fba8189`](https://github.com/jellyfin/jellyfin/commit/fba8189278d9c55afcaf88c4a2ec22444c54b777) Normalize nuget includes in csproj, remove legacy ProductGuid - [`ac9baf5`](https://github.com/jellyfin/jellyfin/commit/ac9baf510b4e5d689128e7f410f6a2d432c0fe3f) A bit more cleanup ### 📊 Changes **27 files changed** (+45 additions, -270 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Naming/Emby.Naming.csproj` (+2 -27) 📝 `Emby.Photos/Emby.Photos.csproj` (+1 -6) 📝 `Emby.Server.Implementations/Emby.Server.Implementations.csproj` (+1 -6) 📝 `Jellyfin.Api/Jellyfin.Api.csproj` (+0 -5) 📝 `Jellyfin.Data/Jellyfin.Data.csproj` (+2 -19) 📝 `Jellyfin.Server.Implementations/Jellyfin.Server.Implementations.csproj` (+1 -1) 📝 `Jellyfin.Server/Jellyfin.Server.csproj` (+1 -6) 📝 `MediaBrowser.Common/MediaBrowser.Common.csproj` (+2 -27) 📝 `MediaBrowser.Controller/MediaBrowser.Controller.csproj` (+2 -27) 📝 `MediaBrowser.LocalMetadata/MediaBrowser.LocalMetadata.csproj` (+1 -6) 📝 `MediaBrowser.MediaEncoding/MediaBrowser.MediaEncoding.csproj` (+1 -6) 📝 `MediaBrowser.Model/MediaBrowser.Model.csproj` (+1 -26) 📝 `MediaBrowser.Providers/MediaBrowser.Providers.csproj` (+1 -6) 📝 `MediaBrowser.XbmcMetadata/MediaBrowser.XbmcMetadata.csproj` (+1 -6) ➕ `Project.Nuget.targets` (+21 -0) 📝 `src/Jellyfin.Database/Jellyfin.Database.Implementations/Jellyfin.Database.Implementations.csproj` (+2 -18) 📝 `src/Jellyfin.Drawing.Skia/Jellyfin.Drawing.Skia.csproj` (+0 -5) 📝 `src/Jellyfin.Drawing/Jellyfin.Drawing.csproj` (+0 -5) 📝 `src/Jellyfin.Extensions/Jellyfin.Extensions.csproj` (+3 -20) 📝 `src/Jellyfin.MediaEncoding.Keyframes/Jellyfin.MediaEncoding.Keyframes.csproj` (+2 -13) _...and 7 more files_ </details> ### 📄 Description Simplifies build automation Edit- I went too far. We can simplify the nuget packages but I think moving GenerateAssemblyInfo broke this --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo added the

pull-request

label 2025-12-22 10:18:27 +01:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#14085

No description provided.

Rows
Columns