[PR #14991] [MERGED] Fix contributing artist query #14034

New issue

Closed

opened 2025-12-22 10:16:28 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 10:16:28 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14991
Author: @theguymadmax
Created: 10/12/2025
Status: ✅ Merged
Merged: 10/13/2025
Merged by: @crobibero

Base: master ← Head: fix-contributing-artists

📝 Commits (2)

6067360 Fix contributing artist query
1a182a5 Update ArtistIds

📊 Changes

2 files changed (+40 additions, -2 deletions)

View changed files

📝 Jellyfin.Server.Implementations/Item/BaseItemRepository.cs (+13 -2)
📝 src/Jellyfin.Database/Jellyfin.Database.Implementations/JellyfinQueryHelperExtensions.cs (+27 -0)

📄 Description

The ContributingArtistIds query included items where the artist appeared as both a contributing and album artist, without properly excluding the latter.

Changes

Filter items where the artist appears as a contributing artist
Explicitly exclude items where the same artist also appears as an album artist
Update ArtistIds filter to check both ItemValueType.Artist and ItemValueType.AlbumArtist
Added WhereReferencedItemMultipleTypes helper method

Issues
Fixes #14980

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14991 **Author:** [@theguymadmax](https://github.com/theguymadmax) **Created:** 10/12/2025 **Status:** ✅ Merged **Merged:** 10/13/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `fix-contributing-artists` --- ### 📝 Commits (2) - [`6067360`](https://github.com/jellyfin/jellyfin/commit/60673602ed419ebbe4afd903f874f0b0dec5ab4a) Fix contributing artist query - [`1a182a5`](https://github.com/jellyfin/jellyfin/commit/1a182a5e6374c03c0d184af4659b057bd7d5696b) Update ArtistIds ### 📊 Changes **2 files changed** (+40 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Server.Implementations/Item/BaseItemRepository.cs` (+13 -2) 📝 `src/Jellyfin.Database/Jellyfin.Database.Implementations/JellyfinQueryHelperExtensions.cs` (+27 -0) </details> ### 📄 Description  The `ContributingArtistIds` query included items where the artist appeared as both a contributing and album artist, without properly excluding the latter. **Changes** - Filter items where the artist appears as a contributing artist - Explicitly exclude items where the same artist also appears as an album artist - Update `ArtistIds` filter to check both `ItemValueType.Artist` and `ItemValueType.AlbumArtist` - Added `WhereReferencedItemMultipleTypes` helper method **Issues** Fixes #14980 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 10:16:28 +01:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#14034

No description provided.

Rows
Columns