[PR #14724] [MERGED] Skip non-media folders in movie resolver #13904

New issue

Closed

opened 2025-12-22 10:08:17 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 10:08:17 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14724
Author: @theguymadmax
Created: 8/31/2025
Status: ✅ Merged
Merged: 9/7/2025
Merged by: @Bond-009

Base: master ← Head: movie-directory-filtering

📝 Commits (2)

792b9a6 Skip non-media folders in movie resolver
a19641b Ignorepatterns first

📊 Changes

3 files changed (+12 additions, -5 deletions)

View changed files

📝 Emby.Server.Implementations/Library/CoreResolutionIgnoreRule.cs (+5 -5)
📝 Emby.Server.Implementations/Library/IgnorePatterns.cs (+2 -0)
📝 Emby.Server.Implementations/Library/Resolvers/Movies/MovieResolver.cs (+5 -0)

📄 Description

Changes
CoreResolutionIgnoreRule:

The addition of parent?.IsTopParent check in #14540 broadened the scope of the top-level folder exception, causing hidden folders and other IgnorePatterns matches to bypass filtering. This PR reorders the checks to evaluate IgnorePatterns first.

MovieResolver:

Added AllExtrasTypesFolderNames check to ensure extra folders are not processed as a multiDiscFolders

IgnorePatterns:

Adds Subs folder as an ignore directory

Issues
Fixes #14646 (Regression)
Fixes hidden folders being scanned into libraries. (Regression)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14724 **Author:** [@theguymadmax](https://github.com/theguymadmax) **Created:** 8/31/2025 **Status:** ✅ Merged **Merged:** 9/7/2025 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `movie-directory-filtering` --- ### 📝 Commits (2) - [`792b9a6`](https://github.com/jellyfin/jellyfin/commit/792b9a68da48fac57bc120f1d7a74bd4bc8679ca) Skip non-media folders in movie resolver - [`a19641b`](https://github.com/jellyfin/jellyfin/commit/a19641b73414314e45058e79f29658f231af3a03) Ignorepatterns first ### 📊 Changes **3 files changed** (+12 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/CoreResolutionIgnoreRule.cs` (+5 -5) 📝 `Emby.Server.Implementations/Library/IgnorePatterns.cs` (+2 -0) 📝 `Emby.Server.Implementations/Library/Resolvers/Movies/MovieResolver.cs` (+5 -0) </details> ### 📄 Description  **Changes** CoreResolutionIgnoreRule: The addition of `parent?.IsTopParent` check in #14540 broadened the scope of the top-level folder exception, causing hidden folders and other IgnorePatterns matches to bypass filtering. This PR reorders the checks to evaluate IgnorePatterns first. MovieResolver: - Added `AllExtrasTypesFolderNames` check to ensure extra folders are not processed as a multiDiscFolders IgnorePatterns: - Adds `Subs` folder as an ignore directory **Issues** Fixes #14646 (Regression) Fixes hidden folders being scanned into libraries. (Regression) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 10:08:17 +01:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#13904

No description provided.

Rows
Columns