[PR #13726] Enable segment deletion for livestreams that are transcoded or remuxed #13499

New issue

Open

opened 2025-12-22 09:54:01 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 09:54:01 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13726
Author: @timminator
Created: 3/17/2025
Status: 🔄 Open

Base: master ← Head: enable-segment-deletion-for-livestreams

📝 Commits (1)

1fc6066 Enable segment deletion for livestreams

📊 Changes

4 files changed (+47 additions, -6 deletions)

View changed files

📝 Emby.Server.Implementations/Session/SessionManager.cs (+21 -0)
📝 MediaBrowser.Controller/MediaEncoding/TranscodingSegmentCleaner.cs (+16 -3)
📝 MediaBrowser.Controller/Session/ISessionManager.cs (+7 -0)
📝 MediaBrowser.MediaEncoding/Transcoding/TranscodeManager.cs (+3 -3)

📄 Description

This PR enables segment deletion for livestreams that are transcoded or remuxed.

The problem I ran into was that livestreams do not report the value downloadpositionticks to reflect the current watch position.
I came up with the idea to use the positionticks value reported in the OnPlaybackProgressinfo class. This worked perfectly and segments are now correctly deleted after the specified time by "Time to keep segments".

Fixes #13725

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13726 **Author:** [@timminator](https://github.com/timminator) **Created:** 3/17/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `enable-segment-deletion-for-livestreams` --- ### 📝 Commits (1) - [`1fc6066`](https://github.com/jellyfin/jellyfin/commit/1fc6066536fdcdd71509c6e887eedcf28f97aa5b) Enable segment deletion for livestreams ### 📊 Changes **4 files changed** (+47 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Session/SessionManager.cs` (+21 -0) 📝 `MediaBrowser.Controller/MediaEncoding/TranscodingSegmentCleaner.cs` (+16 -3) 📝 `MediaBrowser.Controller/Session/ISessionManager.cs` (+7 -0) 📝 `MediaBrowser.MediaEncoding/Transcoding/TranscodeManager.cs` (+3 -3) </details> ### 📄 Description This PR enables segment deletion for livestreams that are transcoded or remuxed. The problem I ran into was that livestreams do not report the value downloadpositionticks to reflect the current watch position. I came up with the idea to use the positionticks value reported in the OnPlaybackProgressinfo class. This worked perfectly and segments are now correctly deleted after the specified time by "Time to keep segments". Fixes #13725 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo added the

pull-request

label 2025-12-22 09:54:01 +01:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#13499

No description provided.

Rows
Columns