[PR #13556] [MERGED] Don't allow usernames to have leading or trailing spaces #13446

New issue

Closed

opened 2025-12-22 09:52:06 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 09:52:06 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13556
Author: @Jxiced
Created: 2/14/2025
Status: ✅ Merged
Merged: 2/20/2025
Merged by: @Bond-009

Base: master ← Head: master

📝 Commits (4)

a0ab0eb Update ThrowIfInvalidUsername to include whitespaces.
237c1d9 Update regex and revert previous changes to ThrowIfInvalidUsername.
b5fcbfc Update test cases.
84450bb Update Jellyfin.Server.Implementations/Users/UserManager.cs

📊 Changes

2 files changed (+5 additions, -1 deletions)

View changed files

📝 Jellyfin.Server.Implementations/Users/UserManager.cs (+1 -1)
📝 tests/Jellyfin.Server.Implementations.Tests/Users/UserManagerTests.cs (+4 -0)

📄 Description

Changes
Perform a trim on the entered username and throw a different exception if the name exists but with a whitespace.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13556 **Author:** [@Jxiced](https://github.com/Jxiced) **Created:** 2/14/2025 **Status:** ✅ Merged **Merged:** 2/20/2025 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`a0ab0eb`](https://github.com/jellyfin/jellyfin/commit/a0ab0eb8758a2b51b905771e4ef2c30a733047cb) Update ThrowIfInvalidUsername to include whitespaces. - [`237c1d9`](https://github.com/jellyfin/jellyfin/commit/237c1d9b976f58a8b1dec1018626debe334246c6) Update regex and revert previous changes to ThrowIfInvalidUsername. - [`b5fcbfc`](https://github.com/jellyfin/jellyfin/commit/b5fcbfc15eef9845f21ecbeaea954d44394b0a5c) Update test cases. - [`84450bb`](https://github.com/jellyfin/jellyfin/commit/84450bb2972c00307c9eb17111df35a9316de4af) Update Jellyfin.Server.Implementations/Users/UserManager.cs ### 📊 Changes **2 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Server.Implementations/Users/UserManager.cs` (+1 -1) 📝 `tests/Jellyfin.Server.Implementations.Tests/Users/UserManagerTests.cs` (+4 -0) </details> ### 📄 Description **Changes** Perform a trim on the entered username and throw a different exception if the name exists but with a whitespace. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 09:52:06 +01:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#13446

No description provided.

Rows
Columns