[PR #13187] [MERGED] Properly check LAN IP in HasRemoteAccess #13315

Closed
opened 2025-12-22 09:47:31 +01:00 by backuprepo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13187
Author: @gnattu
Created: 12/8/2024
Status: Merged
Merged: 12/9/2024
Merged by: @Bond-009

Base: release-10.10.zHead: properly-check-lan


📝 Commits (1)

  • 2a96b8b Properly check LAN IP in HasRemoteAccess

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/Jellyfin.Networking/Manager/NetworkManager.cs (+1 -1)

📄 Description

We cannot simply use the subnet list to check if the IP is in LAN as it does not handle special cases like IPv4MappedToIPv6 and IPv6 loopback addresses.

Changes

Issues

Fixes #13054


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13187 **Author:** [@gnattu](https://github.com/gnattu) **Created:** 12/8/2024 **Status:** ✅ Merged **Merged:** 12/9/2024 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `release-10.10.z` ← **Head:** `properly-check-lan` --- ### 📝 Commits (1) - [`2a96b8b`](https://github.com/jellyfin/jellyfin/commit/2a96b8b34bb7edc94559972686dac568fd6253d1) Properly check LAN IP in HasRemoteAccess ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Jellyfin.Networking/Manager/NetworkManager.cs` (+1 -1) </details> ### 📄 Description We cannot simply use the subnet list to check if the IP is in LAN as it does not handle special cases like IPv4MappedToIPv6 and IPv6 loopback addresses. <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes #13054 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
backuprepo 2025-12-22 09:47:31 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#13315
No description provided.