mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-23 23:20:51 +01:00
[PR #13187] [MERGED] Properly check LAN IP in HasRemoteAccess #13315
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#13315
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/13187
Author: @gnattu
Created: 12/8/2024
Status: ✅ Merged
Merged: 12/9/2024
Merged by: @Bond-009
Base:
release-10.10.z← Head:properly-check-lan📝 Commits (1)
2a96b8bProperly check LAN IP in HasRemoteAccess📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
src/Jellyfin.Networking/Manager/NetworkManager.cs(+1 -1)📄 Description
We cannot simply use the subnet list to check if the IP is in LAN as it does not handle special cases like IPv4MappedToIPv6 and IPv6 loopback addresses.
Changes
Issues
Fixes #13054
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.