[PR #12534] [MERGED] Add new tonemap mode options #13059

Closed
opened 2025-12-22 09:38:49 +01:00 by backuprepo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12534
Author: @gnattu
Created: 8/29/2024
Status: Merged
Merged: 8/29/2024
Merged by: @Bond-009

Base: masterHead: new-tonemap-mode


📝 Commits (1)

  • 298fe97 Add new tonemap mode options

📊 Changes

1 file changed (+12 additions, -6 deletions)

View changed files

📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+12 -6)

📄 Description

Changes

This adds the new tonemap modes introduced in jellyfin-ffmpeg to be selectable, and currently available in CUDA, OpenCL and Metal implementation. One implementation detail to be discussed is how we deal with the vulkan pipeline for AMGPUs on Linux now. Currently if the user select the new modes LUM or ITP, it will do nothing for vulkan pipeline using libplacebo as those modes does not exists in libplacbo. Should we also implement the OpenCL pipeline for AMDGPU under linux and use that when these modes are selected?

Issues

See the following PRs:
https://github.com/jellyfin/jellyfin-ffmpeg/pull/430
https://github.com/jellyfin/jellyfin-ffmpeg/pull/438


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12534 **Author:** [@gnattu](https://github.com/gnattu) **Created:** 8/29/2024 **Status:** ✅ Merged **Merged:** 8/29/2024 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `new-tonemap-mode` --- ### 📝 Commits (1) - [`298fe97`](https://github.com/jellyfin/jellyfin/commit/298fe97ab2c71d4df66557910c90760427621dc8) Add new tonemap mode options ### 📊 Changes **1 file changed** (+12 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+12 -6) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> This adds the new tonemap modes introduced in jellyfin-ffmpeg to be selectable, and currently available in CUDA, OpenCL and Metal implementation. One implementation detail to be discussed is how we deal with the vulkan pipeline for AMGPUs on Linux now. Currently if the user select the new modes LUM or ITP, it will do nothing for vulkan pipeline using libplacebo as those modes does not exists in libplacbo. Should we also implement the OpenCL pipeline for AMDGPU under linux and use that when these modes are selected? **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> See the following PRs: https://github.com/jellyfin/jellyfin-ffmpeg/pull/430 https://github.com/jellyfin/jellyfin-ffmpeg/pull/438 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
backuprepo 2025-12-22 09:38:49 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#13059
No description provided.