mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-23 23:20:51 +01:00
[PR #12534] [MERGED] Add new tonemap mode options #13059
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#13059
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/12534
Author: @gnattu
Created: 8/29/2024
Status: ✅ Merged
Merged: 8/29/2024
Merged by: @Bond-009
Base:
master← Head:new-tonemap-mode📝 Commits (1)
298fe97Add new tonemap mode options📊 Changes
1 file changed (+12 additions, -6 deletions)
View changed files
📝
MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs(+12 -6)📄 Description
Changes
This adds the new tonemap modes introduced in jellyfin-ffmpeg to be selectable, and currently available in CUDA, OpenCL and Metal implementation. One implementation detail to be discussed is how we deal with the vulkan pipeline for AMGPUs on Linux now. Currently if the user select the new modes LUM or ITP, it will do nothing for vulkan pipeline using libplacebo as those modes does not exists in libplacbo. Should we also implement the OpenCL pipeline for AMDGPU under linux and use that when these modes are selected?
Issues
See the following PRs:
https://github.com/jellyfin/jellyfin-ffmpeg/pull/430
https://github.com/jellyfin/jellyfin-ffmpeg/pull/438
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.