[PR #12293] [CLOSED] Add env var to always use legacy audio prober #12955

Closed
opened 2025-12-22 09:35:17 +01:00 by backuprepo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12293
Author: @gnattu
Created: 7/16/2024
Status: Closed

Base: release-10.9.zHead: env-use-legacy-audio-prober


📝 Commits (1)

  • b227c30 Add env var to always use legacy audio prober

📊 Changes

1 file changed (+37 additions, -32 deletions)

View changed files

📝 MediaBrowser.Providers/MediaInfo/AudioFileProber.cs (+37 -32)

📄 Description

Our current TagLib-based audio prober only processes spec-defined multi-value tags. For non-standard methods, like using a special character as a separator, TagLib simply does not support them. Properly implementing such mechanisms is beyond the scope of version 10.9, as it would introduce API changes for additional user settings. Add an environment variable so users can choose to always use the legacy ffprobe results, which process some separators, when re-tagging the library with the spec defined method is not an option.

Changes

Issues

Workaround for #11871 #12256 #10730 #10794


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12293 **Author:** [@gnattu](https://github.com/gnattu) **Created:** 7/16/2024 **Status:** ❌ Closed **Base:** `release-10.9.z` ← **Head:** `env-use-legacy-audio-prober` --- ### 📝 Commits (1) - [`b227c30`](https://github.com/jellyfin/jellyfin/commit/b227c30ac00bd9ec67ecde87335412e4376154c6) Add env var to always use legacy audio prober ### 📊 Changes **1 file changed** (+37 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/MediaInfo/AudioFileProber.cs` (+37 -32) </details> ### 📄 Description Our current TagLib-based audio prober only processes spec-defined multi-value tags. For non-standard methods, like using a special character as a separator, TagLib simply does not support them. Properly implementing such mechanisms is beyond the scope of version 10.9, as it would introduce API changes for additional user settings. Add an environment variable so users can choose to always use the legacy ffprobe results, which process some separators, when re-tagging the library with the spec defined method is not an option. <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Workaround for #11871 #12256 #10730 #10794 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
backuprepo 2025-12-22 09:35:17 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#12955
No description provided.