[PR #12245] [CLOSED] Broken Image Downloads for Azure Storage files. #12934

New issue

Closed

opened 2025-12-22 09:34:38 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 09:34:38 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12245
Author: @mjohl
Created: 7/9/2024
Status: ❌ Closed

Base: master ← Head: fix_broken_image_downloads_to_cache

📝 Commits (3)

353d6d4 Fixed an annoying exception in the log that made it far bigger than needed. As I was here, fixed the root cause for the exception as well.
1f2efd1 Redundant if removed and log level set to match caller. Boilerplate comments removed.
3eb70e4 Swtich replaced with GetMimeType utility method

📊 Changes

3 files changed (+36 additions, -10 deletions)

View changed files

📝 Emby.Server.Implementations/Library/LibraryManager.cs (+18 -9)
📝 Jellyfin.Api/Controllers/ImageController.cs (+9 -1)
📝 MediaBrowser.Providers/Manager/ProviderManager.cs (+9 -0)

📄 Description

Changes

Improved error handling on image download failures to prevent log flooding and provide more info about the status code from the source.
Addition to the SaveImage method to handle application/octet-stream from Azure Blob Storage when providers do not set the content type.

Issues
#12143

Pre-Change

Post-Change

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12245 **Author:** [@mjohl](https://github.com/mjohl) **Created:** 7/9/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_broken_image_downloads_to_cache` --- ### 📝 Commits (3) - [`353d6d4`](https://github.com/jellyfin/jellyfin/commit/353d6d4a57f4096073fa5bc404a68fa252e29869) Fixed an annoying exception in the log that made it far bigger than needed. As I was here, fixed the root cause for the exception as well. - [`1f2efd1`](https://github.com/jellyfin/jellyfin/commit/1f2efd1505e20c5299b8b0d3efbd25316975088c) Redundant if removed and log level set to match caller. Boilerplate comments removed. - [`3eb70e4`](https://github.com/jellyfin/jellyfin/commit/3eb70e4ef30d6b3c19f629df14b03f86911d2348) Swtich replaced with GetMimeType utility method ### 📊 Changes **3 files changed** (+36 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+18 -9) 📝 `Jellyfin.Api/Controllers/ImageController.cs` (+9 -1) 📝 `MediaBrowser.Providers/Manager/ProviderManager.cs` (+9 -0) </details> ### 📄 Description  **Changes** - Improved error handling on image download failures to prevent log flooding and provide more info about the status code from the source. - Addition to the SaveImage method to handle application/octet-stream from Azure Blob Storage when providers do not set the content type. **Issues** #12143 Pre-Change ![Screenshot 2024-07-07 164602](https://github.com/jellyfin/jellyfin/assets/4193377/a02bfa96-0616-4444-9a33-cf3d37eb1d42) Post-Change ![Screenshot 2024-07-07 164921](https://github.com/jellyfin/jellyfin/assets/4193377/492d7f9a-477e-406d-920b-2ca78c03c713) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 09:34:38 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 09:45:04 +01:00

[PR #12934] [MERGED] Fix playlists #13242

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#12934

No description provided.

Rows
Columns