[PR #12126] [MERGED] Try to add extracted lyrics during scanning #12915

Closed
opened 2025-12-22 09:34:01 +01:00 by backuprepo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12126
Author: @gnattu
Created: 6/18/2024
Status: Merged
Merged: 6/24/2024
Merged by: @Bond-009

Base: release-10.9.zHead: add-extracted-lyrics


📝 Commits (2)

  • 31237f7 Try to add extracted lyrics during scanning
  • 10cd9a7 Only add first stream

📊 Changes

1 file changed (+9 additions, -1 deletions)

View changed files

📝 MediaBrowser.Providers/MediaInfo/AudioFileProber.cs (+9 -1)

📄 Description

Changes

The extraction process does not add the extracted lyrics to the audio media streams. Try to add it when tryExtractEmbeddedLyrics is true.

Issues

Fixes #11960


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12126 **Author:** [@gnattu](https://github.com/gnattu) **Created:** 6/18/2024 **Status:** ✅ Merged **Merged:** 6/24/2024 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `release-10.9.z` ← **Head:** `add-extracted-lyrics` --- ### 📝 Commits (2) - [`31237f7`](https://github.com/jellyfin/jellyfin/commit/31237f778a0d73cf64f6d56a85cd9ba24d610f11) Try to add extracted lyrics during scanning - [`10cd9a7`](https://github.com/jellyfin/jellyfin/commit/10cd9a7f7914c671109473254ff7e359e1a50c79) Only add first stream ### 📊 Changes **1 file changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/MediaInfo/AudioFileProber.cs` (+9 -1) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> The extraction process does not add the extracted lyrics to the audio media streams. Try to add it when tryExtractEmbeddedLyrics is true. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes #11960 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
backuprepo 2025-12-22 09:34:01 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#12915
No description provided.