[PR #12028] [MERGED] Fix replace all and respect metadata settings #12891

New issue

Closed

opened 2025-12-22 09:33:12 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 09:33:12 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12028
Author: @Shadowghost
Created: 6/7/2024
Status: ✅ Merged
Merged: 6/15/2024
Merged by: @Bond-009

Base: release-10.9.z ← Head: fix-replace

📝 Commits (2)

e4f3f0b Remove all data when replacing all
ec82023 Respect different metadata settings on refresh

📊 Changes

2 files changed (+4 additions, -1 deletions)

View changed files

📝 Jellyfin.Api/Controllers/ItemRefreshController.cs (+2 -1)
📝 MediaBrowser.Providers/Manager/MetadataService.cs (+2 -0)

📄 Description

Metadata fields are not cleared on replace if the newly fetched metadata does not include it.
Additionally, previously set language options for metadata are also replaced which should not be the case.

Changes

Clear existing fields on replace all
Respect previously set metadata language options on replace all

Issues
Fixes #5236
Fixes #12015
Fixes #12021
Possibly fixes #11923

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12028 **Author:** [@Shadowghost](https://github.com/Shadowghost) **Created:** 6/7/2024 **Status:** ✅ Merged **Merged:** 6/15/2024 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `release-10.9.z` ← **Head:** `fix-replace` --- ### 📝 Commits (2) - [`e4f3f0b`](https://github.com/jellyfin/jellyfin/commit/e4f3f0b3b68d7b14bad6cc45fa6191285e22c3ac) Remove all data when replacing all - [`ec82023`](https://github.com/jellyfin/jellyfin/commit/ec82023265929dcd95f3b3976c507d8551ddba41) Respect different metadata settings on refresh ### 📊 Changes **2 files changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/ItemRefreshController.cs` (+2 -1) 📝 `MediaBrowser.Providers/Manager/MetadataService.cs` (+2 -0) </details> ### 📄 Description Metadata fields are not cleared on replace if the newly fetched metadata does not include it. Additionally, previously set language options for metadata are also replaced which should not be the case. **Changes** * Clear existing fields on replace all * Respect previously set metadata language options on replace all **Issues** Fixes #5236 Fixes #12015 Fixes #12021 Possibly fixes #11923 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>