[PR #11792] [MERGED] Improve reliability of HasChanged check #12819

Closed
opened 2025-12-22 09:30:49 +01:00 by backuprepo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/11792
Author: @Shadowghost
Created: 5/22/2024
Status: Merged
Merged: 5/24/2024
Merged by: @crobibero

Base: release-10.9.zHead: has-changed-safer


📝 Commits (3)

  • 80ea779 Improve reliability of HasChanged check
  • 7c65fdd Apply review suggestions
  • acc05b4 Use ordinal comparison

📊 Changes

1 file changed (+12 additions, -15 deletions)

View changed files

📝 MediaBrowser.Providers/MediaInfo/ProbeProvider.cs (+12 -15)

📄 Description

Before we write the Paths to the item we check for distinction. This should be done on the comparison too. I threw in ordering to prevent issues of potential FS inconsistent return values.

Issues
Potentially #11783


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/11792 **Author:** [@Shadowghost](https://github.com/Shadowghost) **Created:** 5/22/2024 **Status:** ✅ Merged **Merged:** 5/24/2024 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `release-10.9.z` ← **Head:** `has-changed-safer` --- ### 📝 Commits (3) - [`80ea779`](https://github.com/jellyfin/jellyfin/commit/80ea7790b48711b1ae96361bd5c6a684defa2242) Improve reliability of HasChanged check - [`7c65fdd`](https://github.com/jellyfin/jellyfin/commit/7c65fdd6643bb657719635fe652f6fdf01d20a34) Apply review suggestions - [`acc05b4`](https://github.com/jellyfin/jellyfin/commit/acc05b40cb0f197d2ef91838e40453c8b15455b9) Use ordinal comparison ### 📊 Changes **1 file changed** (+12 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/MediaInfo/ProbeProvider.cs` (+12 -15) </details> ### 📄 Description Before we write the Paths to the item we check for distinction. This should be done on the comparison too. I threw in ordering to prevent issues of potential FS inconsistent return values. **Issues** Potentially #11783 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
backuprepo 2025-12-22 09:30:49 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#12819
No description provided.