[PR #11390] [MERGED] Enable nullable for UserItemData #12697

Closed
opened 2025-12-22 09:26:40 +01:00 by backuprepo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/11390
Author: @Bond-009
Created: 4/20/2024
Status: Merged
Merged: 7/29/2024
Merged by: @Bond-009

Base: masterHead: UserItemData


📝 Commits (1)

  • d3f0346 Enable nullable for UserItemData

📊 Changes

9 files changed (+20 additions, -62 deletions)

View changed files

📝 Emby.Server.Implementations/Data/SqliteUserDataRepository.cs (+4 -4)
📝 Emby.Server.Implementations/EntryPoints/UserDataChangeNotifier.cs (+2 -3)
📝 Emby.Server.Implementations/Library/MediaSourceManager.cs (+4 -3)
📝 MediaBrowser.Controller/Entities/UserItemData.cs (+1 -9)
📝 MediaBrowser.Controller/Providers/MetadataResult.cs (+0 -31)
📝 MediaBrowser.Model/Dto/UserItemDataDto.cs (+2 -3)
📝 MediaBrowser.Model/Session/UserDataChangeInfo.cs (+3 -3)
📝 MediaBrowser.XbmcMetadata/Providers/BaseVideoNfoProvider.cs (+0 -5)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/MovieNfoParserTests.cs (+4 -1)

📄 Description

MetadataResult.GetOrAddUserData doesn't ever get used and is probably broken since the migration to .NET Core as it still expects a Guid for userId


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/11390 **Author:** [@Bond-009](https://github.com/Bond-009) **Created:** 4/20/2024 **Status:** ✅ Merged **Merged:** 7/29/2024 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `UserItemData` --- ### 📝 Commits (1) - [`d3f0346`](https://github.com/jellyfin/jellyfin/commit/d3f0346f0498538ae3c0f34e4d17a6e1d044b4f8) Enable nullable for UserItemData ### 📊 Changes **9 files changed** (+20 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Data/SqliteUserDataRepository.cs` (+4 -4) 📝 `Emby.Server.Implementations/EntryPoints/UserDataChangeNotifier.cs` (+2 -3) 📝 `Emby.Server.Implementations/Library/MediaSourceManager.cs` (+4 -3) 📝 `MediaBrowser.Controller/Entities/UserItemData.cs` (+1 -9) 📝 `MediaBrowser.Controller/Providers/MetadataResult.cs` (+0 -31) 📝 `MediaBrowser.Model/Dto/UserItemDataDto.cs` (+2 -3) 📝 `MediaBrowser.Model/Session/UserDataChangeInfo.cs` (+3 -3) 📝 `MediaBrowser.XbmcMetadata/Providers/BaseVideoNfoProvider.cs` (+0 -5) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/MovieNfoParserTests.cs` (+4 -1) </details> ### 📄 Description MetadataResult.GetOrAddUserData doesn't ever get used and is probably broken since the migration to .NET Core as it still expects a Guid for userId --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
backuprepo 2025-12-22 09:26:40 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#12697
No description provided.