[PR #10825] [MERGED] Use helper function to compare guid #12446

New issue

Closed

opened 2025-12-22 09:18:34 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 09:18:34 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/10825
Author: @crobibero
Created: 1/6/2024
Status: ✅ Merged
Merged: 1/17/2024
Merged by: @crobibero

Base: master ← Head: guid-extension

📝 Commits (2)

f2b7655 Use helper function to compare guid
162becc Merge branch 'master' into guid-extension

📊 Changes

58 files changed (+249 additions, -184 deletions)

View changed files

📝 Emby.Server.Implementations/Data/SqliteItemRepository.cs (+16 -16)
📝 Emby.Server.Implementations/EntryPoints/LibraryChangedNotifier.cs (+2 -1)
📝 Emby.Server.Implementations/Library/LibraryManager.cs (+15 -15)
📝 Emby.Server.Implementations/Library/MediaSourceManager.cs (+3 -2)
📝 Emby.Server.Implementations/Library/MusicManager.cs (+2 -1)
📝 Emby.Server.Implementations/Library/SearchEngine.cs (+2 -2)
📝 Emby.Server.Implementations/Library/UserViewManager.cs (+3 -2)
📝 Emby.Server.Implementations/Playlists/PlaylistManager.cs (+2 -1)
📝 Emby.Server.Implementations/Session/SessionManager.cs (+11 -11)
📝 Emby.Server.Implementations/SyncPlay/Group.cs (+2 -1)
📝 Emby.Server.Implementations/TV/TVSeriesManager.cs (+4 -3)
📝 Emby.Server.Implementations/Updates/InstallationManager.cs (+2 -1)
📝 Jellyfin.Api/Auth/DefaultAuthorizationPolicy/DefaultAuthorizationHandler.cs (+2 -1)
📝 Jellyfin.Api/Auth/FirstTimeSetupPolicy/FirstTimeSetupHandler.cs (+2 -1)
📝 Jellyfin.Api/Controllers/ArtistsController.cs (+4 -3)
📝 Jellyfin.Api/Controllers/ChannelsController.cs (+3 -2)
📝 Jellyfin.Api/Controllers/FilterController.cs (+3 -2)
📝 Jellyfin.Api/Controllers/GenresController.cs (+3 -2)
📝 Jellyfin.Api/Controllers/InstantMixController.cs (+8 -7)
📝 Jellyfin.Api/Controllers/ItemsController.cs (+3 -2)

...and 38 more files

📄 Description

I found a few places where we were comparing a nullable guid to default, which isn't what was actually desired.

Double check to make sure I didn't replace anything in an EF call.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/10825 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 1/6/2024 **Status:** ✅ Merged **Merged:** 1/17/2024 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `guid-extension` --- ### 📝 Commits (2) - [`f2b7655`](https://github.com/jellyfin/jellyfin/commit/f2b7655470d488e70caa819b173b6d520b6a4545) Use helper function to compare guid - [`162becc`](https://github.com/jellyfin/jellyfin/commit/162becc24c1e767d7178ef389390c4a12d23fad2) Merge branch 'master' into guid-extension ### 📊 Changes **58 files changed** (+249 additions, -184 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Data/SqliteItemRepository.cs` (+16 -16) 📝 `Emby.Server.Implementations/EntryPoints/LibraryChangedNotifier.cs` (+2 -1) 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+15 -15) 📝 `Emby.Server.Implementations/Library/MediaSourceManager.cs` (+3 -2) 📝 `Emby.Server.Implementations/Library/MusicManager.cs` (+2 -1) 📝 `Emby.Server.Implementations/Library/SearchEngine.cs` (+2 -2) 📝 `Emby.Server.Implementations/Library/UserViewManager.cs` (+3 -2) 📝 `Emby.Server.Implementations/Playlists/PlaylistManager.cs` (+2 -1) 📝 `Emby.Server.Implementations/Session/SessionManager.cs` (+11 -11) 📝 `Emby.Server.Implementations/SyncPlay/Group.cs` (+2 -1) 📝 `Emby.Server.Implementations/TV/TVSeriesManager.cs` (+4 -3) 📝 `Emby.Server.Implementations/Updates/InstallationManager.cs` (+2 -1) 📝 `Jellyfin.Api/Auth/DefaultAuthorizationPolicy/DefaultAuthorizationHandler.cs` (+2 -1) 📝 `Jellyfin.Api/Auth/FirstTimeSetupPolicy/FirstTimeSetupHandler.cs` (+2 -1) 📝 `Jellyfin.Api/Controllers/ArtistsController.cs` (+4 -3) 📝 `Jellyfin.Api/Controllers/ChannelsController.cs` (+3 -2) 📝 `Jellyfin.Api/Controllers/FilterController.cs` (+3 -2) 📝 `Jellyfin.Api/Controllers/GenresController.cs` (+3 -2) 📝 `Jellyfin.Api/Controllers/InstantMixController.cs` (+8 -7) 📝 `Jellyfin.Api/Controllers/ItemsController.cs` (+3 -2) _...and 38 more files_ </details> ### 📄 Description I found a few places where we were comparing a nullable guid to `default`, which isn't what was actually desired. Double check to make sure I didn't replace anything in an EF call. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 09:18:34 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 09:37:30 +01:00

[PR #12446] [MERGED] Remove left-over network path references #13022

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#12446

No description provided.

Rows
Columns