[PR #10781] [MERGED] Remove UserManager Cache #12430

Closed
opened 2025-12-22 09:18:02 +01:00 by backuprepo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/10781
Author: @barronpm
Created: 12/29/2023
Status: Merged
Merged: 1/6/2024
Merged by: @crobibero

Base: masterHead: usermanager-cache


📝 Commits (2)

  • bd0c089 Remove redundant user cache
  • d74c04d Use DI for IPasswordResetProvider and IAuthenticationProvider

📊 Changes

2 files changed (+92 additions, -81 deletions)

View changed files

📝 Jellyfin.Server.Implementations/Users/UserManager.cs (+88 -81)
📝 Jellyfin.Server/CoreAppHost.cs (+4 -0)

📄 Description

Changes

  • Removes the UserManager cache, as queries are already cached by the EFSecondLevelCache.
    This saved roughly ~1s on startup in my testing
  • Uses DI for IAuthenticationProvider and IPasswordResetProvider

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/10781 **Author:** [@barronpm](https://github.com/barronpm) **Created:** 12/29/2023 **Status:** ✅ Merged **Merged:** 1/6/2024 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `usermanager-cache` --- ### 📝 Commits (2) - [`bd0c089`](https://github.com/jellyfin/jellyfin/commit/bd0c0890877d988f9fb308a474f09de7cb2d378d) Remove redundant user cache - [`d74c04d`](https://github.com/jellyfin/jellyfin/commit/d74c04dfab83900cbbac6f48da9296310b4f7bab) Use DI for IPasswordResetProvider and IAuthenticationProvider ### 📊 Changes **2 files changed** (+92 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Server.Implementations/Users/UserManager.cs` (+88 -81) 📝 `Jellyfin.Server/CoreAppHost.cs` (+4 -0) </details> ### 📄 Description **Changes** - Removes the UserManager cache, as queries are already cached by the EFSecondLevelCache. This saved roughly ~1s on startup in my testing - Uses DI for `IAuthenticationProvider` and `IPasswordResetProvider` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
backuprepo 2025-12-22 09:18:02 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#12430
No description provided.