[PR #10737] [MERGED] Make TMDb api key configurable, fix missing/wrong image urls #12414

New issue

Closed

opened 2025-12-22 09:17:31 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 09:17:31 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/10737
Author: @1337joe
Created: 12/17/2023
Status: ✅ Merged
Merged: 12/28/2023
Merged by: @Bond-009

Base: master ← Head: tmdb-plugin-fix

📝 Commits (3)

c8da8ee Add api key to configuration
f7479bc Fix missing posters in collection identify
e91de65 Stop saving Jellyfin API key in settings xml

📊 Changes

5 files changed (+36 additions, -6 deletions)

View changed files

📝 MediaBrowser.Providers/Plugins/Tmdb/BoxSets/TmdbBoxSetProvider.cs (+5 -3)
📝 MediaBrowser.Providers/Plugins/Tmdb/Configuration/PluginConfiguration.cs (+6 -0)
📝 MediaBrowser.Providers/Plugins/Tmdb/Configuration/config.html (+19 -1)
📝 MediaBrowser.Providers/Plugins/Tmdb/Movies/TmdbMovieProvider.cs (+1 -1)
📝 MediaBrowser.Providers/Plugins/Tmdb/TmdbClientManager.cs (+5 -1)

📄 Description

The API key is added to the config file but not the user-facing plugin page. Most users should not mess with the key, but as discussed in #10529 some users like tracking their own API usage or dislike that using the Jellyfin key includes their statistics where someone else could possibly see.

To change the key open the TMDb plugin settings and hit save, then open Jellyfin.Plugin.Tmdb.xml (at ~/.local/share/jellyfin/plugins/configurations/Jellyfin.Plugin.Tmdb.xml in my dev environment), set the TmdbApiKey value, and restart Jellyfin to pick up changes.

An empty or missing TmdbApiKey value will cause Jellyfin to use the Jellyfin key, which will not be saved to the xml file.

Changes

Add API key to configuration file, as well as error handling for the plugin config page in case the key is invalid
Fix missing posters in collection identify page
Fix a case where poster settings were used for person profile images

Issues

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/10737 **Author:** [@1337joe](https://github.com/1337joe) **Created:** 12/17/2023 **Status:** ✅ Merged **Merged:** 12/28/2023 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `tmdb-plugin-fix` --- ### 📝 Commits (3) - [`c8da8ee`](https://github.com/jellyfin/jellyfin/commit/c8da8eefe0ac30a1bb02f0effaf0d38391f3fd7c) Add api key to configuration - [`f7479bc`](https://github.com/jellyfin/jellyfin/commit/f7479bc7301391d1aed9b2cb1104e501087bb6d6) Fix missing posters in collection identify - [`e91de65`](https://github.com/jellyfin/jellyfin/commit/e91de654d78c847d482fb9ca315eca31d044d770) Stop saving Jellyfin API key in settings xml ### 📊 Changes **5 files changed** (+36 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/Plugins/Tmdb/BoxSets/TmdbBoxSetProvider.cs` (+5 -3) 📝 `MediaBrowser.Providers/Plugins/Tmdb/Configuration/PluginConfiguration.cs` (+6 -0) 📝 `MediaBrowser.Providers/Plugins/Tmdb/Configuration/config.html` (+19 -1) 📝 `MediaBrowser.Providers/Plugins/Tmdb/Movies/TmdbMovieProvider.cs` (+1 -1) 📝 `MediaBrowser.Providers/Plugins/Tmdb/TmdbClientManager.cs` (+5 -1) </details> ### 📄 Description The API key is added to the config file but not the user-facing plugin page. Most users should not mess with the key, but as discussed in #10529 some users like tracking their own API usage or dislike that using the Jellyfin key includes their statistics where someone else could possibly see. To change the key open the TMDb plugin settings and hit save, then open `Jellyfin.Plugin.Tmdb.xml` (at `~/.local/share/jellyfin/plugins/configurations/Jellyfin.Plugin.Tmdb.xml` in my dev environment), set the `TmdbApiKey` value, and restart Jellyfin to pick up changes. An empty or missing `TmdbApiKey` value will cause Jellyfin to use the Jellyfin key, which will not be saved to the xml file. **Changes** - Add API key to configuration file, as well as error handling for the plugin config page in case the key is invalid - Fix missing posters in collection identify page - Fix a case where poster settings were used for person profile images **Issues** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 09:17:31 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 09:36:57 +01:00

[PR #12414] [MERGED] Revert "NextUp query respects Limit (#11956)" #13006

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#12414

No description provided.

Rows
Columns