[PR #10682] [MERGED] Fix some warnings in LiveTV #12398

New issue

Closed

opened 2025-12-22 09:17:00 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 09:17:00 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/10682
Author: @barronpm
Created: 12/6/2023
Status: ✅ Merged
Merged: 12/18/2023
Merged by: @Bond-009

Base: master ← Head: livetv-warnings

📝 Commits (10+)

67b4cef Use implementation types in LiveTv
f1a5bc9 Use string.Contains in LiveTv
01480c7 Fix disposable warnings in EmbyTV
ce6c0ad Use ConfigureAwait in DirectRecorder
7bcfc5e Use ConfigureAwait in XmlTvListingsProvider
42c95da Use ConfigureAwait in BaseTunerHost
4ec32b7 Use ConfigureAwait in M3uParser
3ecd68d Use ConfigureAwait in SharedHttpStream
5c593b1 Don't use List directly in ITunerHost method signatures
669baf9 Make IRecorder an IDisposable

📊 Changes

17 files changed (+141 additions, -80 deletions)

View changed files

📝 Emby.Server.Implementations/Library/ExclusiveLiveStream.cs (+6 -1)
📝 Emby.Server.Implementations/LiveTv/EmbyTV/DirectRecorder.cs (+30 -15)
📝 Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs (+4 -14)
📝 Emby.Server.Implementations/LiveTv/EmbyTV/EncodedRecorder.cs (+4 -4)
📝 Emby.Server.Implementations/LiveTv/EmbyTV/IRecorder.cs (+1 -1)
📝 Emby.Server.Implementations/LiveTv/Listings/SchedulesDirect.cs (+2 -2)
📝 Emby.Server.Implementations/LiveTv/Listings/XmlTvListingsProvider.cs (+33 -18)
📝 Emby.Server.Implementations/LiveTv/LiveTvManager.cs (+1 -1)
📝 Emby.Server.Implementations/LiveTv/TunerHosts/BaseTunerHost.cs (+16 -9)
📝 Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/DiscoverResponse.cs (+1 -1)
📝 Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunHost.cs (+1 -1)
📝 Emby.Server.Implementations/LiveTv/TunerHosts/LiveStream.cs (+16 -1)
📝 Emby.Server.Implementations/LiveTv/TunerHosts/M3UTunerHost.cs (+1 -1)
📝 Emby.Server.Implementations/LiveTv/TunerHosts/M3uParser.cs (+1 -1)
📝 Emby.Server.Implementations/LiveTv/TunerHosts/SharedHttpStream.cs (+21 -8)
📝 MediaBrowser.Controller/Library/ILiveStream.cs (+2 -1)
📝 MediaBrowser.Controller/LiveTv/ITunerHost.cs (+1 -1)

📄 Description

Fixes some warnings in LiveTV, mostly relating to ConfigureAwait and the new disposable analyzers.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/10682 **Author:** [@barronpm](https://github.com/barronpm) **Created:** 12/6/2023 **Status:** ✅ Merged **Merged:** 12/18/2023 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `livetv-warnings` --- ### 📝 Commits (10+) - [`67b4cef`](https://github.com/jellyfin/jellyfin/commit/67b4cef77a4b391d5dcf0769d0c70762128ddfd1) Use implementation types in LiveTv - [`f1a5bc9`](https://github.com/jellyfin/jellyfin/commit/f1a5bc955b6a182aaa19a80831560d43c50ede2a) Use string.Contains in LiveTv - [`01480c7`](https://github.com/jellyfin/jellyfin/commit/01480c7f209654a992be6c3d3ad360e9bd343090) Fix disposable warnings in EmbyTV - [`ce6c0ad`](https://github.com/jellyfin/jellyfin/commit/ce6c0ad02bc77b5a43ba2f28d4a93813738d0c53) Use ConfigureAwait in DirectRecorder - [`7bcfc5e`](https://github.com/jellyfin/jellyfin/commit/7bcfc5e925295d386a8bc70b47200254ae731813) Use ConfigureAwait in XmlTvListingsProvider - [`42c95da`](https://github.com/jellyfin/jellyfin/commit/42c95da6b08a5295e1d2f98922158d0702fd8d7e) Use ConfigureAwait in BaseTunerHost - [`4ec32b7`](https://github.com/jellyfin/jellyfin/commit/4ec32b71f5fc765886e457ae2c626ea7227e6a37) Use ConfigureAwait in M3uParser - [`3ecd68d`](https://github.com/jellyfin/jellyfin/commit/3ecd68d832b1849b3bebd052933ce8ad7612bad7) Use ConfigureAwait in SharedHttpStream - [`5c593b1`](https://github.com/jellyfin/jellyfin/commit/5c593b120a5f3b90daa6305a96086eecfe546039) Don't use List directly in ITunerHost method signatures - [`669baf9`](https://github.com/jellyfin/jellyfin/commit/669baf98a577094c5b038c7782045b873d468c0b) Make IRecorder an IDisposable ### 📊 Changes **17 files changed** (+141 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/ExclusiveLiveStream.cs` (+6 -1) 📝 `Emby.Server.Implementations/LiveTv/EmbyTV/DirectRecorder.cs` (+30 -15) 📝 `Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs` (+4 -14) 📝 `Emby.Server.Implementations/LiveTv/EmbyTV/EncodedRecorder.cs` (+4 -4) 📝 `Emby.Server.Implementations/LiveTv/EmbyTV/IRecorder.cs` (+1 -1) 📝 `Emby.Server.Implementations/LiveTv/Listings/SchedulesDirect.cs` (+2 -2) 📝 `Emby.Server.Implementations/LiveTv/Listings/XmlTvListingsProvider.cs` (+33 -18) 📝 `Emby.Server.Implementations/LiveTv/LiveTvManager.cs` (+1 -1) 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/BaseTunerHost.cs` (+16 -9) 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/DiscoverResponse.cs` (+1 -1) 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunHost.cs` (+1 -1) 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/LiveStream.cs` (+16 -1) 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/M3UTunerHost.cs` (+1 -1) 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/M3uParser.cs` (+1 -1) 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/SharedHttpStream.cs` (+21 -8) 📝 `MediaBrowser.Controller/Library/ILiveStream.cs` (+2 -1) 📝 `MediaBrowser.Controller/LiveTv/ITunerHost.cs` (+1 -1) </details> ### 📄 Description Fixes some warnings in LiveTV, mostly relating to `ConfigureAwait` and the new disposable analyzers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>