[PR #10471] [MERGED] chore(deps): use Svg.Skia instead of the deprecated SkiaSharp.Svg #12323

New issue

Closed

opened 2025-12-22 09:14:37 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 09:14:37 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/10471
Author: @cvium
Created: 10/25/2023
Status: ✅ Merged
Merged: 10/27/2023
Merged by: @Bond-009

Base: master ← Head: svg_skia

📝 Commits (1)

4be0f42 chore(deps): use Svg.Skia instead of the deprecated SkiaSharp.Svg

📊 Changes

3 files changed (+13 additions, -16 deletions)

View changed files

📝 Directory.Packages.props (+2 -4)
📝 src/Jellyfin.Drawing.Skia/Jellyfin.Drawing.Skia.csproj (+2 -2)
📝 src/Jellyfin.Drawing.Skia/SkiaEncoder.cs (+9 -10)

📄 Description

Changes
According to https://github.com/mono/SkiaSharp.Extended/issues/83#issuecomment-674318895 we never should've used SkiaSharp.Svg and according to Svg.Skia README, it should be a drop-in replacement:

The Svg.Skia can be used in same way as the SkiaSharp.Extended.Svg (load svg files as SKPicture).

I do not have any SVGs to test with.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/10471 **Author:** [@cvium](https://github.com/cvium) **Created:** 10/25/2023 **Status:** ✅ Merged **Merged:** 10/27/2023 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `svg_skia` --- ### 📝 Commits (1) - [`4be0f42`](https://github.com/jellyfin/jellyfin/commit/4be0f4267d41a4948815ff9a7ca055c1b16dffe1) chore(deps): use Svg.Skia instead of the deprecated SkiaSharp.Svg ### 📊 Changes **3 files changed** (+13 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `Directory.Packages.props` (+2 -4) 📝 `src/Jellyfin.Drawing.Skia/Jellyfin.Drawing.Skia.csproj` (+2 -2) 📝 `src/Jellyfin.Drawing.Skia/SkiaEncoder.cs` (+9 -10) </details> ### 📄 Description  **Changes** According to https://github.com/mono/SkiaSharp.Extended/issues/83#issuecomment-674318895 we never should've used SkiaSharp.Svg and according to [Svg.Skia README](https://github.com/wieslawsoltes/Svg.Skia), it should be a drop-in replacement: > The Svg.Skia can be used in same way as the SkiaSharp.Extended.Svg (load svg files as SKPicture). I do not have any SVGs to test with. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 09:14:37 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 09:35:44 +01:00

[PR #12323] [MERGED] Fix comment in PhotoProvider #12968

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#12323

No description provided.

Rows
Columns