[PR #10356] [CLOSED] Change initialization of root folders to app startup #12268

Closed
opened 2025-12-22 09:12:49 +01:00 by backuprepo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/10356
Author: @Dangles91
Created: 10/7/2023
Status: Closed

Base: masterHead: feature/root-folder-entry


📝 Commits (3)

  • c8e1962 Initialize library root folders on startup
  • a21b1aa Initialize root folders before startup tasks
  • 24a2e73 Skip creating root folders if already initialized

📊 Changes

27 files changed (+254 additions, -220 deletions)

View changed files

📝 Emby.Dlna/ContentDirectory/ControlHandler.cs (+3 -3)
📝 Emby.Server.Implementations/ApplicationHost.cs (+3 -0)
📝 Emby.Server.Implementations/Collections/CollectionManager.cs (+1 -1)
📝 Emby.Server.Implementations/EntryPoints/LibraryChangedNotifier.cs (+2 -2)
📝 Emby.Server.Implementations/IO/LibraryMonitor.cs (+1 -1)
📝 Emby.Server.Implementations/Library/LibraryManager.cs (+13 -156)
📝 Emby.Server.Implementations/Library/UserViewManager.cs (+2 -2)
📝 Emby.Server.Implementations/Library/Validators/CollectionPostScanTask.cs (+1 -1)
📝 Emby.Server.Implementations/Playlists/PlaylistManager.cs (+2 -2)
📝 Emby.Server.Implementations/TV/TVSeriesManager.cs (+1 -1)
📝 Jellyfin.Api/Controllers/ItemsController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/LibraryController.cs (+9 -9)
📝 Jellyfin.Api/Controllers/LiveTvController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/UserLibraryController.cs (+10 -10)
📝 Jellyfin.Api/Controllers/UserViewsController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/VideosController.cs (+2 -2)
📝 MediaBrowser.Controller/Entities/BaseItem.cs (+2 -2)
📝 MediaBrowser.Controller/Entities/CollectionFolder.cs (+1 -1)
📝 MediaBrowser.Controller/Entities/Folder.cs (+2 -2)
📝 MediaBrowser.Controller/Entities/Movies/BoxSet.cs (+2 -1)

...and 7 more files

📄 Description

Changes

  • Remove lazy creation of library root folders
  • Remove double check locking on library roots
  • Move library root references to static properties on LibraryRoot class
  • Reduce dependency on LibraryManager

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/10356 **Author:** [@Dangles91](https://github.com/Dangles91) **Created:** 10/7/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/root-folder-entry` --- ### 📝 Commits (3) - [`c8e1962`](https://github.com/jellyfin/jellyfin/commit/c8e196200a1b6c917a6e5734d6732d1ce776591a) Initialize library root folders on startup - [`a21b1aa`](https://github.com/jellyfin/jellyfin/commit/a21b1aa28fbb0c2ccc4ebcb79baa09f7d7df82cb) Initialize root folders before startup tasks - [`24a2e73`](https://github.com/jellyfin/jellyfin/commit/24a2e7373198da1b3b9fcaff73732b55b8949436) Skip creating root folders if already initialized ### 📊 Changes **27 files changed** (+254 additions, -220 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/ContentDirectory/ControlHandler.cs` (+3 -3) 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+3 -0) 📝 `Emby.Server.Implementations/Collections/CollectionManager.cs` (+1 -1) 📝 `Emby.Server.Implementations/EntryPoints/LibraryChangedNotifier.cs` (+2 -2) 📝 `Emby.Server.Implementations/IO/LibraryMonitor.cs` (+1 -1) 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+13 -156) 📝 `Emby.Server.Implementations/Library/UserViewManager.cs` (+2 -2) 📝 `Emby.Server.Implementations/Library/Validators/CollectionPostScanTask.cs` (+1 -1) 📝 `Emby.Server.Implementations/Playlists/PlaylistManager.cs` (+2 -2) 📝 `Emby.Server.Implementations/TV/TVSeriesManager.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/ItemsController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/LibraryController.cs` (+9 -9) 📝 `Jellyfin.Api/Controllers/LiveTvController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/UserLibraryController.cs` (+10 -10) 📝 `Jellyfin.Api/Controllers/UserViewsController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/VideosController.cs` (+2 -2) 📝 `MediaBrowser.Controller/Entities/BaseItem.cs` (+2 -2) 📝 `MediaBrowser.Controller/Entities/CollectionFolder.cs` (+1 -1) 📝 `MediaBrowser.Controller/Entities/Folder.cs` (+2 -2) 📝 `MediaBrowser.Controller/Entities/Movies/BoxSet.cs` (+2 -1) _...and 7 more files_ </details> ### 📄 Description **Changes** - Remove lazy creation of library root folders - Remove double check locking on library roots - Move library root references to static properties on LibraryRoot class - Reduce dependency on LibraryManager --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
backuprepo 2025-12-22 09:12:49 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#12268
No description provided.