[PR #10135] [MERGED] Fixed probesize argument passing to FFmpeg #12166

Closed
opened 2025-12-22 09:08:47 +01:00 by backuprepo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/10135
Author: @0x25CBFC4F
Created: 8/20/2023
Status: Merged
Merged: 10/6/2023
Merged by: @cvium

Base: masterHead: fix/ffmpeg-probesize


📝 Commits (2)

  • 8dc58e8 Added handling of FFmpeg:probesize variable
  • a18b3fb simplify the if

📊 Changes

2 files changed (+9 additions, -1 deletions)

View changed files

📝 CONTRIBUTORS.md (+1 -0)
📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+8 -1)

📄 Description

While setting up Jellyfish myself I stumbled into issue described in #9984 (related issue is #1713)
Server knows about FFmpeg's probesize variable but it is unused. This PR fixes that.

I should mention that documentation explicitly states that this variable exists so I think this is expected behavior.

Changes

  • I added a code block to EncodingHelper.GetInputModifier that passes probesize argument to FFmpeg.
  • Added myself to CONTRIBUTORS.md

Issues
Fixes #9984


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/10135 **Author:** [@0x25CBFC4F](https://github.com/0x25CBFC4F) **Created:** 8/20/2023 **Status:** ✅ Merged **Merged:** 10/6/2023 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `fix/ffmpeg-probesize` --- ### 📝 Commits (2) - [`8dc58e8`](https://github.com/jellyfin/jellyfin/commit/8dc58e8f04ca891aa8e515c369f14ecbb21d2191) Added handling of FFmpeg:probesize variable - [`a18b3fb`](https://github.com/jellyfin/jellyfin/commit/a18b3fbe70429f55852f0aebeda4e02e2abdef77) simplify the if ### 📊 Changes **2 files changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CONTRIBUTORS.md` (+1 -0) 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+8 -1) </details> ### 📄 Description While setting up Jellyfish myself I stumbled into issue described in #9984 (related issue is #1713) Server knows about FFmpeg's probesize variable but it is unused. This PR fixes that. I should mention that documentation [explicitly states](https://github.com/jellyfin/jellyfin.org/blob/13b92c4e903fd64148dfd6a73fc5059d8eb3f10a/docs/general/administration/configuration.md?plain=1#L105) that this variable exists so I think this is expected behavior. **Changes** - I added a code block to `EncodingHelper.GetInputModifier` that passes `probesize` argument to FFmpeg. - Added myself to CONTRIBUTORS.md **Issues** Fixes #9984 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
backuprepo 2025-12-22 09:08:47 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#12166
No description provided.