mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-23 23:20:51 +01:00
[PR #10135] [MERGED] Fixed probesize argument passing to FFmpeg #12166
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#12166
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/10135
Author: @0x25CBFC4F
Created: 8/20/2023
Status: ✅ Merged
Merged: 10/6/2023
Merged by: @cvium
Base:
master← Head:fix/ffmpeg-probesize📝 Commits (2)
8dc58e8Added handling of FFmpeg:probesize variablea18b3fbsimplify the if📊 Changes
2 files changed (+9 additions, -1 deletions)
View changed files
📝
CONTRIBUTORS.md(+1 -0)📝
MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs(+8 -1)📄 Description
While setting up Jellyfish myself I stumbled into issue described in #9984 (related issue is #1713)
Server knows about FFmpeg's probesize variable but it is unused. This PR fixes that.
I should mention that documentation explicitly states that this variable exists so I think this is expected behavior.
Changes
EncodingHelper.GetInputModifierthat passesprobesizeargument to FFmpeg.Issues
Fixes #9984
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.