[PR #10062] [MERGED] Fix the probing of m4a metadata with missing composer #12145

New issue

Closed

opened 2025-12-22 09:08:06 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 09:08:06 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/10062
Author: @lonebyte
Created: 7/31/2023
Status: ✅ Merged
Merged: 8/1/2023
Merged by: @Bond-009

Base: master ← Head: m4a-metadata-probing-fix

📝 Commits (1)

66ff724 Fix the probing of m4a metadata

📊 Changes

1 file changed (+21 additions, -12 deletions)

View changed files

📝 MediaBrowser.Providers/MediaInfo/AudioFileProber.cs (+21 -12)

📄 Description

Changes
The composer is not set in some of my m4a files. For some reason TagLibSharp returns the composer as an empty string in this case. This causes an exception in PeopleHelper.AddPerson, and thus probing fails.

IMHO we can simply ignore empty values.

Issues
Fixes: #10061

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/10062 **Author:** [@lonebyte](https://github.com/lonebyte) **Created:** 7/31/2023 **Status:** ✅ Merged **Merged:** 8/1/2023 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `m4a-metadata-probing-fix` --- ### 📝 Commits (1) - [`66ff724`](https://github.com/jellyfin/jellyfin/commit/66ff724acf6bac3e8e65773ee46bb698b2cda334) Fix the probing of m4a metadata ### 📊 Changes **1 file changed** (+21 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/MediaInfo/AudioFileProber.cs` (+21 -12) </details> ### 📄 Description **Changes** The composer is not set in some of my m4a files. For some reason TagLibSharp returns the composer as an empty string in this case. This causes an exception in PeopleHelper.AddPerson, and thus probing fails. IMHO we can simply ignore empty values. **Issues** Fixes: #10061 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>