[PR #9607] [MERGED] Fix analyzers warnings and suggestions #11989

New issue

Closed

opened 2025-12-22 09:03:10 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 09:03:10 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/9607
Author: @goremykin
Created: 4/6/2023
Status: ✅ Merged
Merged: 4/10/2023
Merged by: @Bond-009

Base: master ← Head: fix_analyzers_warnings_and_suggestions

📝 Commits (10+)

779a22a Remove redundant Cast
2c03f7e Use TryGetValue
2695816 Remove unused using directives
7d7e177 Remove redundant casts
1c0bb82 Fix argument is not used in message template warning
5508efc Remove bitwise operator on enum that is not marked by [Flags] attribute
08ce477 Fix duplicate properties in message template warning
9d738bb Remove redundant ToString call
6ae1903 Use TryAdd
c051736 Inline out variable declaration

📊 Changes

64 files changed (+238 additions, -300 deletions)

View changed files

📝 Emby.Dlna/Main/DlnaEntryPoint.cs (+0 -1)
📝 Emby.Dlna/PlayTo/TransportCommands.cs (+6 -6)
📝 Emby.Server.Implementations/Data/BaseSqliteRepository.cs (+1 -1)
📝 Emby.Server.Implementations/Data/SqliteItemRepository.cs (+28 -14)
📝 Emby.Server.Implementations/Dto/DtoService.cs (+1 -4)
📝 Emby.Server.Implementations/Library/LibraryManager.cs (+1 -3)
📝 Emby.Server.Implementations/Library/MediaSourceManager.cs (+2 -2)
📝 Emby.Server.Implementations/Library/Resolvers/BaseVideoResolver.cs (+2 -1)
📝 Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs (+3 -6)
📝 Emby.Server.Implementations/LiveTv/Listings/SchedulesDirect.cs (+4 -5)
📝 Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunManager.cs (+1 -1)
📝 Emby.Server.Implementations/LiveTv/TunerHosts/M3uParser.cs (+1 -2)
📝 Emby.Server.Implementations/Localization/LocalizationManager.cs (+6 -6)
📝 Emby.Server.Implementations/Session/SessionManager.cs (+2 -2)
📝 Emby.Server.Implementations/SyncPlay/Group.cs (+4 -8)
📝 Emby.Server.Implementations/SyncPlay/SyncPlayManager.cs (+2 -4)
📝 Jellyfin.Api/Controllers/FilterController.cs (+0 -1)
📝 Jellyfin.Api/Controllers/QuickConnectController.cs (+0 -2)
📝 Jellyfin.Api/Controllers/SearchController.cs (+0 -1)
📝 Jellyfin.Api/Controllers/SubtitleController.cs (+2 -4)

...and 44 more files

📄 Description

Changes
This PR is mostly about cleanup and fixing analyzers warnings.
Some changes may seem controversial or a matter of taste, so all changes are grouped by type of warning/suggestion (see commit names) to make it easy to rollback any you don't like.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/9607 **Author:** [@goremykin](https://github.com/goremykin) **Created:** 4/6/2023 **Status:** ✅ Merged **Merged:** 4/10/2023 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `fix_analyzers_warnings_and_suggestions` --- ### 📝 Commits (10+) - [`779a22a`](https://github.com/jellyfin/jellyfin/commit/779a22a76adf61484571e5cae5cb6fb978f94ed0) Remove redundant Cast - [`2c03f7e`](https://github.com/jellyfin/jellyfin/commit/2c03f7e85d9bca7b243f0021f454b6bfd780d2f3) Use TryGetValue - [`2695816`](https://github.com/jellyfin/jellyfin/commit/26958162d01ea9557d80f384face93012f70b821) Remove unused using directives - [`7d7e177`](https://github.com/jellyfin/jellyfin/commit/7d7e177265a6725b58669a2717af85c031f67996) Remove redundant casts - [`1c0bb82`](https://github.com/jellyfin/jellyfin/commit/1c0bb828d23859df363e46d18462c425ae1680fa) Fix argument is not used in message template warning - [`5508efc`](https://github.com/jellyfin/jellyfin/commit/5508efc2e27400e05a22e75a08baf69c7cb1d808) Remove bitwise operator on enum that is not marked by [Flags] attribute - [`08ce477`](https://github.com/jellyfin/jellyfin/commit/08ce4772262cab7961ea1000b0a9dd536244a667) Fix duplicate properties in message template warning - [`9d738bb`](https://github.com/jellyfin/jellyfin/commit/9d738bb60159b4846554f7d15c325130296ad9eb) Remove redundant ToString call - [`6ae1903`](https://github.com/jellyfin/jellyfin/commit/6ae1903453102a4bb6159b755e503ce0e0bae2f6) Use TryAdd - [`c051736`](https://github.com/jellyfin/jellyfin/commit/c051736c800c56767e238ccf2b93054cf5a719f1) Inline out variable declaration ### 📊 Changes **64 files changed** (+238 additions, -300 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/Main/DlnaEntryPoint.cs` (+0 -1) 📝 `Emby.Dlna/PlayTo/TransportCommands.cs` (+6 -6) 📝 `Emby.Server.Implementations/Data/BaseSqliteRepository.cs` (+1 -1) 📝 `Emby.Server.Implementations/Data/SqliteItemRepository.cs` (+28 -14) 📝 `Emby.Server.Implementations/Dto/DtoService.cs` (+1 -4) 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+1 -3) 📝 `Emby.Server.Implementations/Library/MediaSourceManager.cs` (+2 -2) 📝 `Emby.Server.Implementations/Library/Resolvers/BaseVideoResolver.cs` (+2 -1) 📝 `Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs` (+3 -6) 📝 `Emby.Server.Implementations/LiveTv/Listings/SchedulesDirect.cs` (+4 -5) 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunManager.cs` (+1 -1) 📝 `Emby.Server.Implementations/LiveTv/TunerHosts/M3uParser.cs` (+1 -2) 📝 `Emby.Server.Implementations/Localization/LocalizationManager.cs` (+6 -6) 📝 `Emby.Server.Implementations/Session/SessionManager.cs` (+2 -2) 📝 `Emby.Server.Implementations/SyncPlay/Group.cs` (+4 -8) 📝 `Emby.Server.Implementations/SyncPlay/SyncPlayManager.cs` (+2 -4) 📝 `Jellyfin.Api/Controllers/FilterController.cs` (+0 -1) 📝 `Jellyfin.Api/Controllers/QuickConnectController.cs` (+0 -2) 📝 `Jellyfin.Api/Controllers/SearchController.cs` (+0 -1) 📝 `Jellyfin.Api/Controllers/SubtitleController.cs` (+2 -4) _...and 44 more files_ </details> ### 📄 Description **Changes** This PR is mostly about cleanup and fixing analyzers warnings. Some changes may seem controversial or a matter of taste, so all changes are grouped by type of warning/suggestion (see commit names) to make it easy to rollback any you don't like. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 09:03:10 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 09:32:51 +01:00

[PR #11989] [MERGED] Fix fallback artist when taglib fails #12879

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#11989

No description provided.

Rows
Columns