[PR #8087] [MERGED] feat: make subtitleeditparser generic #11436

New issue

Closed

opened 2025-12-22 08:45:05 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 08:45:05 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/8087
Author: @cvium
Created: 7/8/2022
Status: ✅ Merged
Merged: 8/1/2022
Merged by: @Bond-009

Base: release-10.8.z ← Head: generic_subtitleparser

📝 Commits (9)

1db7483 feat: make subtitleeditparser generic
78f4374 loop over all compatible SubtitleFormats
dbfa0f3 fix unsupported
126da94 use reflection to get all subtitle formats without causing libse configuration loading
3b69f38 fix tests
b0b4068 Update MediaBrowser.MediaEncoding/Subtitles/SubtitleEditParser.cs
f2c7bcc Update MediaBrowser.MediaEncoding/Subtitles/SubtitleEditParser.cs
a380153 remove redundant null check
d258a87 Update MediaBrowser.MediaEncoding/Subtitles/SubtitleEditParser.cs

📊 Changes

10 files changed (+98 additions, -119 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+3 -1)
➖ MediaBrowser.MediaEncoding/Subtitles/AssParser.cs (+0 -19)
📝 MediaBrowser.MediaEncoding/Subtitles/ISubtitleParser.cs (+9 -3)
➖ MediaBrowser.MediaEncoding/Subtitles/SrtParser.cs (+0 -19)
➖ MediaBrowser.MediaEncoding/Subtitles/SsaParser.cs (+0 -19)
📝 MediaBrowser.MediaEncoding/Subtitles/SubtitleEditParser.cs (+72 -13)
📝 MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs (+8 -39)
📝 tests/Jellyfin.MediaEncoding.Tests/Subtitles/AssParserTests.cs (+1 -1)
📝 tests/Jellyfin.MediaEncoding.Tests/Subtitles/SrtParserTests.cs (+2 -2)
📝 tests/Jellyfin.MediaEncoding.Tests/Subtitles/SsaParserTests.cs (+3 -3)

📄 Description

Changes
Instead of hard coding and wrapping every SubtitleFormat sub class, this introduces a generic parser that tries all available SubtitleFormat based on extension.

Issues
Supercedes #8086

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/8087 **Author:** [@cvium](https://github.com/cvium) **Created:** 7/8/2022 **Status:** ✅ Merged **Merged:** 8/1/2022 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `release-10.8.z` ← **Head:** `generic_subtitleparser` --- ### 📝 Commits (9) - [`1db7483`](https://github.com/jellyfin/jellyfin/commit/1db748399cfad140c28e92cd44a5ea630a0bd5ea) feat: make subtitleeditparser generic - [`78f4374`](https://github.com/jellyfin/jellyfin/commit/78f437401b836edc8fc535eb5d46506e58a64329) loop over all compatible SubtitleFormats - [`dbfa0f3`](https://github.com/jellyfin/jellyfin/commit/dbfa0f30276054b63402e95867ed9a9f1b1cca08) fix unsupported - [`126da94`](https://github.com/jellyfin/jellyfin/commit/126da94020385952cbba08dad76a575452b76aa8) use reflection to get all subtitle formats without causing libse configuration loading - [`3b69f38`](https://github.com/jellyfin/jellyfin/commit/3b69f38a1f6c5c9e1ccfa148980180900a10aa85) fix tests - [`b0b4068`](https://github.com/jellyfin/jellyfin/commit/b0b4068ddfaeed023d20c0c96ffa992bcaaee505) Update MediaBrowser.MediaEncoding/Subtitles/SubtitleEditParser.cs - [`f2c7bcc`](https://github.com/jellyfin/jellyfin/commit/f2c7bccb891293cec9ca814e285ea1bb7f6c1155) Update MediaBrowser.MediaEncoding/Subtitles/SubtitleEditParser.cs - [`a380153`](https://github.com/jellyfin/jellyfin/commit/a380153f92969b151fc0bc26948b6b8d96475846) remove redundant null check - [`d258a87`](https://github.com/jellyfin/jellyfin/commit/d258a87fdaf58c3a16602301f7e9079ac42200ab) Update MediaBrowser.MediaEncoding/Subtitles/SubtitleEditParser.cs ### 📊 Changes **10 files changed** (+98 additions, -119 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+3 -1) ➖ `MediaBrowser.MediaEncoding/Subtitles/AssParser.cs` (+0 -19) 📝 `MediaBrowser.MediaEncoding/Subtitles/ISubtitleParser.cs` (+9 -3) ➖ `MediaBrowser.MediaEncoding/Subtitles/SrtParser.cs` (+0 -19) ➖ `MediaBrowser.MediaEncoding/Subtitles/SsaParser.cs` (+0 -19) 📝 `MediaBrowser.MediaEncoding/Subtitles/SubtitleEditParser.cs` (+72 -13) 📝 `MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs` (+8 -39) 📝 `tests/Jellyfin.MediaEncoding.Tests/Subtitles/AssParserTests.cs` (+1 -1) 📝 `tests/Jellyfin.MediaEncoding.Tests/Subtitles/SrtParserTests.cs` (+2 -2) 📝 `tests/Jellyfin.MediaEncoding.Tests/Subtitles/SsaParserTests.cs` (+3 -3) </details> ### 📄 Description  **Changes** Instead of hard coding and wrapping every `SubtitleFormat` sub class, this introduces a generic parser that tries all available `SubtitleFormat` based on extension. **Issues** Supercedes #8086 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 08:45:05 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 09:27:30 +01:00

[PR #11436] [MERGED] Require elevation for plugin related endpoints #12721

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#11436

No description provided.

Rows
Columns