[PR #7947] [MERGED] Add VideoRangeType to video conditions #11395

New issue

Closed

opened 2025-12-22 08:43:31 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 08:43:31 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/7947
Author: @nyanmisaka
Created: 6/16/2022
Status: ✅ Merged
Merged: 6/17/2022
Merged by: @crobibero

Base: release-10.8.z ← Head: video-range-condition

📝 Commits (3)

be72001 Add VideoRangeType to video conditions
477b922 Apply suggestions from code review
0b6fbeb Apply suggestions from code review

📊 Changes

14 files changed (+190 additions, -30 deletions)

View changed files

📝 Emby.Dlna/Didl/DidlBuilder.cs (+2 -0)
📝 Emby.Dlna/PlayTo/PlayToController.cs (+1 -0)
📝 Jellyfin.Api/Helpers/StreamingHelpers.cs (+2 -1)
📝 MediaBrowser.Controller/MediaEncoding/BaseEncodingJobOptions.cs (+6 -0)
📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+14 -0)
📝 MediaBrowser.Controller/MediaEncoding/EncodingJobInfo.cs (+42 -0)
📝 MediaBrowser.Model/Dlna/ConditionProcessor.cs (+3 -0)
📝 MediaBrowser.Model/Dlna/ContentFeatureBuilder.cs (+2 -0)
📝 MediaBrowser.Model/Dlna/DeviceProfile.cs (+3 -1)
📝 MediaBrowser.Model/Dlna/ProfileConditionValue.cs (+2 -1)
📝 MediaBrowser.Model/Dlna/StreamBuilder.cs (+41 -4)
📝 MediaBrowser.Model/Dlna/StreamInfo.cs (+23 -0)
📝 MediaBrowser.Model/Entities/MediaStream.cs (+48 -23)
📝 MediaBrowser.Model/Session/TranscodeReason.cs (+1 -0)

📄 Description

This is used to distinguish whether the client supports specific VideoRangeType, such as SDR, HDR10, HLG and DOVI.
Since it's basically a copy-paste from the Video Profile condition, usages are similar.

@dmitrylyzo has tried to add the "IsHdr" condition in https://github.com/jellyfin/jellyfin/pull/7199, but I think that's isn't enough for various HDR types mentioned above.

With this PR, clients can declare supported video range types by querying device attributes. Server will follow the condition from clients to make a right decision between using Transcoding, DirectPlay, DirectStreaming or Remuxing.

Web
https://github.com/jellyfin/jellyfin-web/pull/3713

Changes

Add VideoRangeType to video conditions

Issues
Should fixes https://github.com/jellyfin/jellyfin-roku/issues/552 if roku client implement this.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/7947 **Author:** [@nyanmisaka](https://github.com/nyanmisaka) **Created:** 6/16/2022 **Status:** ✅ Merged **Merged:** 6/17/2022 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `release-10.8.z` ← **Head:** `video-range-condition` --- ### 📝 Commits (3) - [`be72001`](https://github.com/jellyfin/jellyfin/commit/be72001ff91d61a51b5746e5686d806308f0aa39) Add VideoRangeType to video conditions - [`477b922`](https://github.com/jellyfin/jellyfin/commit/477b922e4a1d74f4af91d2561c9f30d527489105) Apply suggestions from code review - [`0b6fbeb`](https://github.com/jellyfin/jellyfin/commit/0b6fbebf72d650fe6708f298ce7a45663c9c833d) Apply suggestions from code review ### 📊 Changes **14 files changed** (+190 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/Didl/DidlBuilder.cs` (+2 -0) 📝 `Emby.Dlna/PlayTo/PlayToController.cs` (+1 -0) 📝 `Jellyfin.Api/Helpers/StreamingHelpers.cs` (+2 -1) 📝 `MediaBrowser.Controller/MediaEncoding/BaseEncodingJobOptions.cs` (+6 -0) 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+14 -0) 📝 `MediaBrowser.Controller/MediaEncoding/EncodingJobInfo.cs` (+42 -0) 📝 `MediaBrowser.Model/Dlna/ConditionProcessor.cs` (+3 -0) 📝 `MediaBrowser.Model/Dlna/ContentFeatureBuilder.cs` (+2 -0) 📝 `MediaBrowser.Model/Dlna/DeviceProfile.cs` (+3 -1) 📝 `MediaBrowser.Model/Dlna/ProfileConditionValue.cs` (+2 -1) 📝 `MediaBrowser.Model/Dlna/StreamBuilder.cs` (+41 -4) 📝 `MediaBrowser.Model/Dlna/StreamInfo.cs` (+23 -0) 📝 `MediaBrowser.Model/Entities/MediaStream.cs` (+48 -23) 📝 `MediaBrowser.Model/Session/TranscodeReason.cs` (+1 -0) </details> ### 📄 Description This is used to distinguish whether the client supports specific VideoRangeType, such as SDR, HDR10, HLG and DOVI. **Since it's basically a copy-paste from the Video Profile condition, usages are similar.** @dmitrylyzo has tried to add the "IsHdr" condition in https://github.com/jellyfin/jellyfin/pull/7199, but I think that's isn't enough for various HDR types mentioned above. With this PR, clients can declare supported video range types by querying device attributes. Server will follow the condition from clients to make a right decision between using Transcoding, DirectPlay, DirectStreaming or Remuxing. **Web** https://github.com/jellyfin/jellyfin-web/pull/3713 **Changes** - Add VideoRangeType to video conditions **Issues** Should fixes https://github.com/jellyfin/jellyfin-roku/issues/552 if roku client implement this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 08:43:31 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 09:26:46 +01:00

[PR #11395] [MERGED] Fix WebSocket disconnecting when exception is thrown during processing #12698

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#11395

No description provided.

Rows
Columns