mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-01-23 23:20:51 +01:00
[PR #7338] [MERGED] fix HLS transcoding on android tv -- dont use -noaccurate_seek for hls transcode #11171
Labels
No labels
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
EFjellyfin.db
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: starred/jellyfin#11171
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/7338
Author: @mueslimak3r
Created: 2/19/2022
Status: ✅ Merged
Merged: 3/1/2022
Merged by: @crobibero
Base:
master← Head:hls-remove-seek-param📝 Commits (1)
36cdeaadont use noaccurate_seek for hls📊 Changes
1 file changed (+1 additions, -0 deletions)
View changed files
📝
MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs(+1 -0)📄 Description
Changes
Issues
exoplayer in the Android TV client would get chunks with video that starts earlier than their timestamps. Typically it would be around 4 seconds behind.
when testing with https://github.com/jellyfin/jellyfin/pull/6600 on Android-TV I found segments were still inaccurate (off by the time difference between two keyframes), even though the requested time was keyframe-aligned. I assume this is because even though the requested timestamp is keyframe aligned, ffmpeg still only goes up until the preceding keyframe.
This issue also occurred in the android (mobile) client using the web player backend
The main resulting issue is that subtitles handled externally can't be synced to the video
Notes
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.