[PR #6820] [CLOSED] Add/expose image settings for video extras #10969

New issue

Closed

opened 2025-12-22 08:27:19 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 08:27:19 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6820
Author: @1337joe
Created: 11/10/2021
Status: ❌ Closed

Base: master ← Head: expose-extras-options

📝 Commits (2)

3046128 Add/expose settings for video extras
0a00dd5 Revert trailer fallback to video

📊 Changes

3 files changed (+24 additions, -6 deletions)

View changed files

📝 Emby.Server.Implementations/Library/LibraryManager.cs (+15 -2)
📝 Jellyfin.Api/Controllers/LibraryController.cs (+3 -3)
📝 MediaBrowser.Controller/Entities/BaseItem.cs (+6 -1)

📄 Description

Old state: If no library TypeOptions are found for a type a default option is used that enables all image providers. This allows the usage of a dummy object for populating the options panel, but results in image providers that the user disabled for Movie being run on any extras, trailers, or secondary video files also in the directory with the primary movie file.

Changes

Fall back to Owner on missing Parent when searching up the tree for the library root to allow options to be found for owned items.
Fall back to Video when type Trailer not found in library options.
Add check to ensure owned videos know their owner on metadata refresh (videos created from the Video.LocalAlternateVersions list didn't know their owner).
Add Video library options to allow the user to modify image collection settings for video extras.

"Extras" would be a better name for the library options, but options are looked up by type name, and in this case the problematic files were of type types Trailer or Video.

Issues
Possibly related to #2355

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6820 **Author:** [@1337joe](https://github.com/1337joe) **Created:** 11/10/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `expose-extras-options` --- ### 📝 Commits (2) - [`3046128`](https://github.com/jellyfin/jellyfin/commit/30461280d1447f21a6f42cb358aa8401282dd766) Add/expose settings for video extras - [`0a00dd5`](https://github.com/jellyfin/jellyfin/commit/0a00dd59826019d71354bf52437b24bbb6f3955e) Revert trailer fallback to video ### 📊 Changes **3 files changed** (+24 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+15 -2) 📝 `Jellyfin.Api/Controllers/LibraryController.cs` (+3 -3) 📝 `MediaBrowser.Controller/Entities/BaseItem.cs` (+6 -1) </details> ### 📄 Description Old state: If no library `TypeOptions` are found for a type a default option is used that enables all image providers. This allows the usage of a dummy object for populating the options panel, but results in image providers that the user disabled for `Movie` being run on any extras, trailers, or secondary video files also in the directory with the primary movie file. **Changes** - Fall back to `Owner` on missing `Parent` when searching up the tree for the library root to allow options to be found for owned items. - Fall back to `Video` when type `Trailer` not found in library options. - Add check to ensure owned videos know their owner on metadata refresh (videos created from the `Video.LocalAlternateVersions` list didn't know their owner). - Add `Video` library options to allow the user to modify image collection settings for video extras. "Extras" would be a better name for the library options, but options are looked up by type name, and in this case the problematic files were of type types `Trailer` or `Video`. **Issues** Possibly related to #2355 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 08:27:20 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 09:20:22 +01:00

[PR #10969] [MERGED] Progress cleanup #12499

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#10969

No description provided.

Rows
Columns