[PR #6281] [MERGED] Reduce warnings in MediaBrowser.Controller #10710

New issue

Closed

opened 2025-12-22 08:16:36 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 08:16:36 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6281
Author: @crobibero
Created: 7/10/2021
Status: ✅ Merged
Merged: 7/20/2021
Merged by: @Bond-009

Base: master ← Head: controller-warn-04

📝 Commits (2)

4281722 Fix [SA1629] Documentation text should end with a period
65f8d8c [CA1801] Parameter is never used. Remove the parameter or use it in the method body.

📊 Changes

10 files changed (+23 additions, -39 deletions)

View changed files

📝 Emby.Server.Implementations/Collections/CollectionManager.cs (+1 -1)
📝 Emby.Server.Implementations/Playlists/PlaylistManager.cs (+1 -1)
📝 Jellyfin.Api/Controllers/DynamicHlsController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/VideoHlsController.cs (+1 -1)
📝 MediaBrowser.Controller/Entities/Folder.cs (+1 -14)
📝 MediaBrowser.Controller/Entities/UserViewBuilder.cs (+13 -16)
📝 MediaBrowser.Controller/LiveTv/LiveTvChannel.cs (+1 -1)
📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+2 -2)
📝 MediaBrowser.Controller/Providers/ItemLookupInfo.cs (+1 -1)
📝 MediaBrowser.Providers/TV/SeriesMetadataService.cs (+1 -1)

📄 Description

Fixes:
[SA1629] Documentation text should end with a period
[CA1801] Parameter is never used. Remove the parameter or use it in the method body.

Remaining:
CA1711
CA2227
CA1002
CA1819
SA1201
SA1622
CA1051
SA1401
SA1306
CA1008
CA1721
SA1214
CA2211
SA1203
CA1044
SA1615
SA1611
SA1618
SA1627
CA1707
SA1614
CA1508
SA1617
CA1826
CA1835
CA1033
CA1724
CA1711
SA1629

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6281 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 7/10/2021 **Status:** ✅ Merged **Merged:** 7/20/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `controller-warn-04` --- ### 📝 Commits (2) - [`4281722`](https://github.com/jellyfin/jellyfin/commit/4281722d5a50347c26ee92dcd47b3bbad5cedbbf) Fix [SA1629] Documentation text should end with a period - [`65f8d8c`](https://github.com/jellyfin/jellyfin/commit/65f8d8c0cd6cf64cebcbc0cc9279d9857ebf343c) [CA1801] Parameter is never used. Remove the parameter or use it in the method body. ### 📊 Changes **10 files changed** (+23 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Collections/CollectionManager.cs` (+1 -1) 📝 `Emby.Server.Implementations/Playlists/PlaylistManager.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/DynamicHlsController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/VideoHlsController.cs` (+1 -1) 📝 `MediaBrowser.Controller/Entities/Folder.cs` (+1 -14) 📝 `MediaBrowser.Controller/Entities/UserViewBuilder.cs` (+13 -16) 📝 `MediaBrowser.Controller/LiveTv/LiveTvChannel.cs` (+1 -1) 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+2 -2) 📝 `MediaBrowser.Controller/Providers/ItemLookupInfo.cs` (+1 -1) 📝 `MediaBrowser.Providers/TV/SeriesMetadataService.cs` (+1 -1) </details> ### 📄 Description Fixes: [SA1629] Documentation text should end with a period [CA1801] Parameter is never used. Remove the parameter or use it in the method body. Remaining: CA1711 CA2227 CA1002 CA1819 SA1201 SA1622 CA1051 SA1401 SA1306 CA1008 CA1721 SA1214 CA2211 SA1203 CA1044 SA1615 SA1611 SA1618 SA1627 CA1707 SA1614 CA1508 SA1617 CA1826 CA1835 CA1033 CA1724 CA1711 SA1629 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 08:16:36 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 09:17:20 +01:00

[PR #10710] [MERGED] Use eof_action=pass when overlaying subtitles #12408

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#10710

No description provided.

Rows
Columns