[PR #6031] [MERGED] Run SQLite query planner optimization at shutdown/restart #10603

New issue

Closed

opened 2025-12-22 08:12:48 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 08:12:48 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6031
Author: @ferferga
Created: 5/11/2021
Status: ✅ Merged
Merged: 5/24/2021
Merged by: @cvium

Base: master ← Head: sql-optimization

📝 Commits (3)

69baa9c Run SQLite query planner optimization at shutdown/restart
3b82211 Create scheduled task for database optimization
6db229a Address review comments

📊 Changes

5 files changed (+118 additions, -2 deletions)

View changed files

📝 Emby.Server.Implementations/Emby.Server.Implementations.csproj (+1 -0)
📝 Emby.Server.Implementations/Localization/Core/en-US.json (+3 -1)
📝 Emby.Server.Implementations/Localization/Core/es.json (+3 -1)
➕ Emby.Server.Implementations/ScheduledTasks/Tasks/OptimizeDatabaseTask.cs (+101 -0)
📝 Jellyfin.Server/Program.cs (+10 -0)

📄 Description

Runs PRAGMA optimize after disposing Jellyfin's application host. According to SQLite docs, this should be run at the end of the connection, when it's most suitable to run the query planner optimizations.

Source https://www.sqlite.org/pragma.html#pragma_optimize and https://sqlite.org/lang_analyze.html

EFCore arbitrarily creates or reuses connections for database contexts (based in EF6, not EFCore documentation I could find, https://docs.microsoft.com/en-us/ef/ef6/fundamentals/connection-management) but I assume that with SQLite provider (given all the concurrency issues it has) the same connection is reused no matter what, so we're taking full advantage of the query planner. More insights on this are appreciated.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6031 **Author:** [@ferferga](https://github.com/ferferga) **Created:** 5/11/2021 **Status:** ✅ Merged **Merged:** 5/24/2021 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `sql-optimization` --- ### 📝 Commits (3) - [`69baa9c`](https://github.com/jellyfin/jellyfin/commit/69baa9c4679d376f001cc71ec0a0d9a1791e7adf) Run SQLite query planner optimization at shutdown/restart - [`3b82211`](https://github.com/jellyfin/jellyfin/commit/3b822116ed8b89da82d5b90cd0fdca070def6377) Create scheduled task for database optimization - [`6db229a`](https://github.com/jellyfin/jellyfin/commit/6db229af5deb6a00035ddcfebc4fd9db3b6a5336) Address review comments ### 📊 Changes **5 files changed** (+118 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Emby.Server.Implementations.csproj` (+1 -0) 📝 `Emby.Server.Implementations/Localization/Core/en-US.json` (+3 -1) 📝 `Emby.Server.Implementations/Localization/Core/es.json` (+3 -1) ➕ `Emby.Server.Implementations/ScheduledTasks/Tasks/OptimizeDatabaseTask.cs` (+101 -0) 📝 `Jellyfin.Server/Program.cs` (+10 -0) </details> ### 📄 Description Runs ``PRAGMA optimize`` after disposing Jellyfin's application host. According to SQLite docs, this should be run at the end of the connection, when it's most suitable to run the query planner optimizations. Source https://www.sqlite.org/pragma.html#pragma_optimize and https://sqlite.org/lang_analyze.html EFCore arbitrarily creates or reuses connections for database contexts (based in EF6, not EFCore documentation I could find, https://docs.microsoft.com/en-us/ef/ef6/fundamentals/connection-management) but I assume that with SQLite provider (given all the concurrency issues it has) the same connection is reused no matter what, so we're taking full advantage of the query planner. **More insights on this are appreciated**. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 08:12:48 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 09:16:11 +01:00

[PR #10603] [MERGED] Refactor Dockerfile and build #12374

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#10603

No description provided.

Rows
Columns